netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shangw@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, divy@chelsio.com
Subject: Re: [PATCH] net/CXGB3: Avoid access MMIO on offlined PCI dev
Date: Sat, 27 Jul 2013 20:14:21 -0700 (PDT)	[thread overview]
Message-ID: <20130727.201421.864510110128224403.davem@davemloft.net> (raw)
In-Reply-To: <1374737524-8410-1-git-send-email-shangw@linux.vnet.ibm.com>

From: Gavin Shan <shangw@linux.vnet.ibm.com>
Date: Thu, 25 Jul 2013 15:32:04 +0800

> While we have EEH errors happened on specific PCI device, the PE
> (Partitionable Endpoint) which includes the PCI device is expected
> to be reset. During the reset, the PCI device should have been
> marked as "offline" and it's not safe to access MMIO of that PCI
> device with "offline" state. That might cause the failure to do
> EEH recovery and then the PCI device is removed from the system for
> ever before manual recovery.
> 
> The patch avoids access to MMIO while the PCI device has been marked
> "offline" so that to avoid additional EEH errors during reset and make
> sure that the EEH recovery can be done successfully.
> 
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>

Making this check on every single register read or write is not
reasonable.

If this is how register access in every driver has to be done in order
to support EEH errors properly, it is simply not acceptable.

      reply	other threads:[~2013-07-28  3:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25  7:32 Gavin Shan
2013-07-28  3:14 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130727.201421.864510110128224403.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=divy@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=shangw@linux.vnet.ibm.com \
    --subject='Re: [PATCH] net/CXGB3: Avoid access MMIO on offlined PCI dev' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).