From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
Narendra_K@Dell.com, bhutchings@solarflare.com,
john.r.fastabend@intel.com, or.gerlitz@gmail.com,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, gregory.v.rose@intel.com,
peter.p.waskiewicz.jr@intel.com, alexander.h.duyck@intel.com,
john.ronciak@intel.com, tushar.n.dave@intel.com,
matthew.vick@intel.com, mitch.a.williams@intel.com,
vyasevic@redhat.com, amwang@redhat.com,
johannes@sipsolutions.net
Subject: Re: [patch net-next v5 0/4] export device physical port id to userspace
Date: Mon, 29 Jul 2013 12:17:19 +0200 [thread overview]
Message-ID: <20130729101719.GA1703@minipsycho.brq.redhat.com> (raw)
In-Reply-To: <20130728.131531.1999841614812208345.davem@davemloft.net>
Sun, Jul 28, 2013 at 10:15:31PM CEST, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Fri, 26 Jul 2013 14:09:52 +0200
>
>> This patchset is based on patch by Narendra_K@Dell.com
>> Once device which can change phys port id during its lifetime adopts this,
>> NETDEV_CHANGEPHYSPORTID event will be added and driver will call
>> call_netdevice_notifiers(NETDEV_NETDEV_CHANGEPHYSPORTID, dev) to propagate
>> the change to userspace.
>
>I'm generally fine with these patches, but some things still need to be
>done.
>
>First of all, I want a real comprehensive description of this patch
>series in the "0/4" posting.
>
>It should answer, in detail, the following questions:
>
>1) Why do we need this, and why do existing facilities fail to provide
> a way to accomplish this?
>
>2) Why is the physical port ID defined as a 32 byte opaque cookie?
> What formats and layouts need to be accomodated, and which
> influenced the design of the ID?
>
>3) Are IDs globally unique? Why or why not? If IDs should be
> globally unique, but only in certain cases, what exactly are those
> cases.
>
>And please address Ben's concerns about global uniqueness in the
>igb/igbvf changes, and whether a 32-bit value is sufficient.
Will do. Thanks Dave
>
>Thanks.
prev parent reply other threads:[~2013-07-29 10:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 12:09 [patch net-next v5 0/4] export device physical port id to userspace Jiri Pirko
2013-07-26 12:09 ` [patch net-next v5 1/4] net: add ndo to get id of physical port of the device Jiri Pirko
2013-07-26 12:09 ` [patch net-next v5 2/4] rtnl: export physical port id via RT netlink Jiri Pirko
2013-07-26 12:09 ` [patch net-next v5 3/4] net: export physical port id via sysfs Jiri Pirko
2013-07-26 12:09 ` [patch net-next v5 4/4] igb/igbvf: implement ndo_get_phys_port_id Jiri Pirko
2013-07-26 13:08 ` Jeff Kirsher
2013-07-26 15:09 ` Ben Hutchings
2013-07-29 11:42 ` Jiri Pirko
2013-07-26 13:06 ` [patch net-next v5 0/4] export device physical port id to userspace Jeff Kirsher
2013-07-28 20:15 ` David Miller
2013-07-29 10:17 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729101719.GA1703@minipsycho.brq.redhat.com \
--to=jiri@resnulli.us \
--cc=Narendra_K@Dell.com \
--cc=alexander.h.duyck@intel.com \
--cc=amwang@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=stephen@networkplumber.org \
--cc=tushar.n.dave@intel.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).