From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes
Date: Tue, 30 Jul 2013 00:10:01 -0700 (PDT) [thread overview]
Message-ID: <20130730.001001.618776305200728182.davem@davemloft.net> (raw)
In-Reply-To: <1374602291.3387.17.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Tue, 23 Jul 2013 10:58:11 -0700
> Function prototypes don't need to be declared
> extern in .h files. It's assumed by the compiler
> and is as unnecessary as using auto is when
> declaring automatic/local variables in a block.
>
> I ran a script to remove these unnecessary extern
> uses from function prototypes in include/net/ as
> well as reflow the function arguments to 80 cols.
>
> It's 370KB, far too large to submit at once.
>
> Of course it could be broken into multiple patches
> for the various directories/subsystems.
No objections from me.
Please submit a small number at a time so that my already overflowing
backlog isn't overwhelmed even more.
Thanks.
next prev parent reply other threads:[~2013-07-30 7:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 17:58 [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes Joe Perches
2013-07-25 1:27 ` Cong Wang
2013-07-25 1:41 ` Joe Perches
2013-07-25 1:47 ` Hannes Frederic Sowa
2013-07-25 2:59 ` [PATCH] checkpatch: Warn when using extern with function prototypes in .h files Joe Perches
2013-08-01 12:21 ` David Howells
2013-08-01 13:00 ` Arend van Spriel
2013-07-30 7:10 ` David Miller [this message]
2013-07-30 7:38 ` [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes Stephen Rothwell
2013-07-30 7:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730.001001.618776305200728182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).