From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] sh_eth: r8a7790: Handle the RFE (Receive FIFO overflow Error) interrupt
Date: Tue, 30 Jul 2013 11:10:25 +0900 [thread overview]
Message-ID: <20130730021025.GC27724@verge.net.au> (raw)
In-Reply-To: <1375142928-17769-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Tue, Jul 30, 2013 at 02:08:48AM +0200, Laurent Pinchart wrote:
> The RFE interrupt is enabled for the r8a7790 but isn't handled,
> resulting in the interrupts core noticing unhandled interrupts, and
> eventually disabling the ethernet IRQ.
>
> Fix it by adding RFE to the bitmask of error interrupts to be handled
> for r8a7790.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
This looks good to me:
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index fedc0a0..9e2afe8 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -403,8 +403,9 @@ static struct sh_eth_cpu_data r8a7790_data = {
> .eesipr_value = 0x01ff009f,
>
> .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO,
> - .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RDE |
> - EESR_RFRMER | EESR_TFE | EESR_TDE | EESR_ECI,
> + .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE |
> + EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE |
> + EESR_ECI,
>
> .apr = 1,
> .mpr = 1,
> --
> Regards,
>
> Laurent Pinchart
>
next prev parent reply other threads:[~2013-07-30 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 0:08 [PATCH] sh_eth: r8a7790: Handle the RFE (Receive FIFO overflow Error) interrupt Laurent Pinchart
2013-07-30 2:10 ` Simon Horman [this message]
2013-07-30 14:17 ` Sergei Shtylyov
2013-07-30 14:20 ` Laurent Pinchart
2013-07-30 14:47 ` Sergei Shtylyov
2013-09-12 19:45 ` Sergei Shtylyov
2013-07-31 0:32 ` Simon Horman
2013-07-30 20:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730021025.GC27724@verge.net.au \
--to=horms@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).