From: Mark Rutland <mark.rutland@arm.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>, netdev <netdev@vger.kernel.org>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Florian Fainelli <florian@openwrt.org>,
Grant Likely <grant.likely@secretlab.ca>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/3] of: provide a binding for the 'fixed-link' property
Date: Tue, 30 Jul 2013 16:31:21 +0100 [thread overview]
Message-ID: <20130730153121.GC29859@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <20130730110705.3262bc3d@skate>
On Tue, Jul 30, 2013 at 10:07:05AM +0100, Thomas Petazzoni wrote:
> Dear Grant Likely,
>
> On Tue, 23 Jul 2013 12:39:52 +0100, Grant Likely wrote:
>
> > > +Such a fixed link situation is described within an Ethernet device
> > > +Device Tree node using a 'fixed-link' property, composed of 5
> > > +elements:
> > > +
> > > + 1. A fake PHY ID, which must be unique accross all fixed-link PHYs in
> > > + the system.
> >
> > That's just loony! :) Regardless of existing code doing this, it is
> > absolutely ridiculous to have it in the driver. The kernel should
> > handle generating a phy id transparently. I'd rather mark this field
> > as reserved in the binding and change the code to not care about it
> > anymore.
>
> In fact, this value is used for two things:
>
> * As the PHY address on the fake "fixed" MDIO bus.
>
> * As the PHY identifier, as reported by the MII registers PHYS_ID1
> (0x2) and PHYS_ID2 (0x3).
>
> I think this doesn't make sense, because the two things are completely
> unrelated. Ideally, we'd like the PHY identifier for fixed PHYs to be
> something fixed, identical for all fixed PHYs. The problem is finding
> an OUI and device number that is available for that, but maybe we can
> ask the OpenMoko people to allocate one (see
> http://wiki.openmoko.org/wiki/OUI).
>
> Then, the PHY address could be generated dynamically. This would
> require:
>
> * Adding a fixed_phy_create() function that internally uses
> fixed_phy_add(), but before that creates an unique PHY address for
> this newly created PHY. Those unique addresses will be generated by
> incrementing a global number of fixed PHYs, up to PHY_MAX_ADDR,
> which is the maximum number of fixed PHYs that can anyway be
> registered on the fixed MDIO bus.
>
> fixed_phy_create() would return this PHY address (positive) on
> success, or a negative error code on failure.
>
> * Change of_phy_register_fixed_link() to call fixed_phy_create()
> instead of fixed_phy_add() and make it return the PHY address
> allocated by fixed_phy_create().
>
> * Add a of_phy_connect_fixed_link_direct() that is similar to
> of_phy_connect_fixed_link() but takes an additional PHY address as
> argument and uses that to generate the 'bus_id' used to find the
> phy_device.
>
> Grant, Mark, Florian, do you have other proposals?
The above sounds good to me.
Thanks,
Mark.
next prev parent reply other threads:[~2013-07-30 15:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 15:34 [RFC PATCH 0/3] Add DT support for fixed PHYs Thomas Petazzoni
2013-07-15 15:34 ` [RFC PATCH 1/3] of: provide a binding for the 'fixed-link' property Thomas Petazzoni
2013-07-15 15:50 ` Florian Fainelli
2013-07-23 11:22 ` Mark Rutland
2013-07-23 11:39 ` Florian Fainelli
2013-07-30 9:16 ` Thomas Petazzoni
2013-07-30 10:26 ` Florian Fainelli
2013-07-30 15:28 ` Mark Rutland
2013-07-23 11:39 ` Grant Likely
2013-07-30 9:07 ` Thomas Petazzoni
2013-07-30 10:05 ` Florian Fainelli
2013-07-30 11:23 ` Thomas Petazzoni
2013-07-30 11:43 ` Florian Fainelli
2013-07-30 15:31 ` Mark Rutland [this message]
2013-08-12 6:38 ` Sascha Hauer
2013-08-12 8:16 ` Thomas Petazzoni
2013-08-12 8:37 ` Sascha Hauer
2013-08-21 10:55 ` Christian Gmeiner
2013-08-21 11:25 ` Florian Fainelli
2013-08-21 11:46 ` Florian Fainelli
2013-07-15 15:34 ` [RFC PATCH 2/3] net: phy: call mdiobus_scan() after adding a fixed PHY Thomas Petazzoni
2013-07-15 15:46 ` Florian Fainelli
2013-07-15 15:34 ` [RFC PATCH 3/3] net: mvneta: add support for fixed links Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730153121.GC29859@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=alior@marvell.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=florian@openwrt.org \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).