netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: u.kleine-koenig@pengutronix.de
Cc: netdev@vger.kernel.org, fabio.estevam@freescale.com,
	Frank.Li@freescale.com, shawn.guo@linaro.org,
	kernel@pengutronix.de, hector.palacios@digi.com,
	tim.sander@hbm.com, rostedt@goodmis.org, tglx@linutronix.de,
	stephen@networkplumber.org, B38611@freescale.com,
	florian@openwrt.org, bhutchings@solarflare.com
Subject: Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link
Date: Wed, 31 Jul 2013 11:51:01 -0700 (PDT)	[thread overview]
Message-ID: <20130731.115101.340503855490269301.davem@davemloft.net> (raw)
In-Reply-To: <20130731081649.GA1754@pengutronix.de>

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 31 Jul 2013 10:16:49 +0200

> On Tue, Jul 30, 2013 at 04:05:30PM -0700, David Miller wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Date: Tue, 30 Jul 2013 11:29:40 +0200
>> 
>> > Don't test for having link and let hardware deal with this situation.
>> > 
>> > Without this patch I see a machine running an -rt patched Linux being
>> > stuck in sch_direct_xmit when it looses link while there is still a
>> > packet to be sent. In this case the fec_enet_start_xmit routine returned
>> > NETDEV_TX_BUSY which makes the network stack reschedule the packet and
>> > so sch_direct_xmit calls fec_enet_start_xmit again.
>> > I failed to reproduce a complete hang without -rt, but I think the
>> > problem exists there, too.
>> > 
>> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> 
>> Applied, thanks.
> Thanks, I see it as a264b981f2c76e281ef27e7232774bf6c54ec865 in net.git
> (i.e.
> https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a264b981f2c76e281ef27e7232774bf6c54ec865)
> 
> You missed to take the
> 
> 	Acked-and-tested-by: Fugang Duan <B38611@freescale.com>

This is not an official tag recognized by patchwork, he should say:

Acked-by: Fugang Duan <B38611@freescale.com>
Tested-by: Fugang Duan <B38611@freescale.com>

> . If you want to fix that, you can do:
> 
> 	git filter-branch --msg-filter 'if test $GIT_COMMIT = a264b981f2c76e281ef27e7232774bf6c54ec865; then sed "/David/ i Acked-and-tested-by: Fugang Duan <B38611@freescale.com>"; else cat; fi' a264b981f2c76e281^..
> 
> on your master branch to add it to that commit.

My GIT history is permanent once pushed out, I cannot change history or else it
would break everyone cloning my tree.

  reply	other threads:[~2013-07-31 18:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 13:27 [PATCH] net/fec: call netif_carrier_off when not having link Uwe Kleine-König
2013-07-25 16:03 ` Stephen Hemminger
2013-07-26  9:35   ` Duan Fugang-B38611
2013-07-26 10:06     ` Florian Fainelli
2013-07-26 10:52       ` Sascha Hauer
2013-07-26 15:31     ` Ben Hutchings
2013-07-29  2:10       ` Duan Fugang-B38611
2013-07-29  2:14       ` Duan Fugang-B38611
2013-07-30  9:29 ` [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY without link Uwe Kleine-König
2013-07-30  9:59   ` Duan Fugang-B38611
2013-07-30 23:05   ` David Miller
2013-07-31  8:16     ` Uwe Kleine-König
2013-07-31 18:51       ` David Miller [this message]
2013-08-01  2:01         ` Duan Fugang-B38611
2013-08-01  2:25           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130731.115101.340503855490269301.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=B38611@freescale.com \
    --cc=Frank.Li@freescale.com \
    --cc=bhutchings@solarflare.com \
    --cc=fabio.estevam@freescale.com \
    --cc=florian@openwrt.org \
    --cc=hector.palacios@digi.com \
    --cc=kernel@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shawn.guo@linaro.org \
    --cc=stephen@networkplumber.org \
    --cc=tglx@linutronix.de \
    --cc=tim.sander@hbm.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).