From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: jonas.jensen@gmail.com, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org,
florian@openwrt.org
Subject: Re: [PATCH v3] net: Add MOXA ART SoCs ethernet driver
Date: Wed, 31 Jul 2013 17:04:46 -0700 (PDT) [thread overview]
Message-ID: <20130731.170446.1534643901297918794.davem@davemloft.net> (raw)
In-Reply-To: <1375296998.5729.8.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Wed, 31 Jul 2013 11:56:38 -0700
>> + if (ui & (RX_ERR | CRC_ERR | FTL | RUNT | RX_ODD_NB)) {
>> + netdev_err(ndev, "packet error\n");
>
> This is generally a bad idea as it can flood
> the log. It's probably better to remove it.
> If you really want logging, then at least use
> net_ratelimit(). Generally, the stats are
> enough.
...
>> + priv->stats.rx_dropped++;
>> + priv->stats.rx_errors++;
> []
>> +static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> []
>> + if (txdesc->txdes0.ubit.tx_dma_own) {
>> + netdev_err(ndev, "no TX space for packet\n");
>> + priv->stats.tx_dropped++;
>
> here too.
Agreed, these should not be logged, the statistics are sufficient.
next prev parent reply other threads:[~2013-08-01 0:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 9:46 [PATCH] net: Add MOXA ART SoCs ethernet driver Jonas Jensen
2013-07-20 10:55 ` Jonas Jensen
2013-07-22 11:09 ` Florian Fainelli
2013-07-26 13:12 ` Jonas Jensen
2013-07-26 12:48 ` [PATCH v2] " Jonas Jensen
2013-07-30 23:24 ` David Miller
2013-07-31 14:20 ` [PATCH v3] " Jonas Jensen
2013-07-31 18:56 ` Joe Perches
2013-08-01 0:04 ` David Miller [this message]
2013-08-01 9:39 ` [PATCH v4] " Jonas Jensen
2013-08-01 22:51 ` David Miller
2013-08-02 10:04 ` Mark Rutland
2013-08-02 10:23 ` Florian Fainelli
2013-08-08 11:34 ` [PATCH v5] " Jonas Jensen
2013-08-12 4:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731.170446.1534643901297918794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian@openwrt.org \
--cc=joe@perches.com \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).