From: Werner Almesberger <werner@almesberger.net>
To: David Miller <davem@davemloft.net>
Cc: hannes@stressinduktion.org, netdev@vger.kernel.org
Subject: Re: minimum ICMPv6 message size vs. RPL's DIS
Date: Fri, 2 Aug 2013 01:51:27 -0300 [thread overview]
Message-ID: <20130802045127.GA5594@ws> (raw)
In-Reply-To: <20130801.181022.1784276332134390788.davem@davemloft.net>
David Miller wrote:
> FWIW I think this is a safe change.
Thanks !
Regarding the change to icmpv6.h, I found that the introduction
of the otherwise very nice and tidy "struct icmp6hdr_head" creates
a conflict with net/bridge/br_multicast.c:br_multicast_ipv6_rcv
which has a variable called "icmp6_type".
While it would be easy enough to rename that variable, this makes
me wonder if the change isn't too intrusive after all, I think
I'd rather go with my original idea and just change the size to 4,
with a comment why and what this is.
I'll post the patches in a bit.
- Werner
prev parent reply other threads:[~2013-08-02 4:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 23:28 minimum ICMPv6 message size vs. RPL's DIS Werner Almesberger
2013-07-25 6:17 ` Hannes Frederic Sowa
2013-07-25 10:30 ` Werner Almesberger
2013-07-25 13:03 ` Hannes Frederic Sowa
2013-07-25 13:58 ` Hannes Frederic Sowa
2013-07-25 14:32 ` Werner Almesberger
2013-07-25 18:40 ` Hannes Frederic Sowa
2013-07-25 21:47 ` Werner Almesberger
2013-07-25 23:31 ` Hannes Frederic Sowa
2013-08-01 5:48 ` Hannes Frederic Sowa
2013-08-02 1:10 ` David Miller
2013-08-02 4:51 ` Werner Almesberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802045127.GA5594@ws \
--to=werner@almesberger.net \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).