From: David Miller <davem@davemloft.net>
To: panweiping3@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net 0/2] tcp: delete redundant calls of tcp_mtup_init() and
Date: Tue, 14 Jan 2014 16:41:05 -0800 (PST) [thread overview]
Message-ID: <20140114.164105.524133214769947013.davem@davemloft.net> (raw)
In-Reply-To: <cover.1389513042.git.panweiping3@gmail.com>
From: Weiping Pan <panweiping3@gmail.com>
Date: Sun, 12 Jan 2014 15:54:29 +0800
> I find that both tcp_v4_syn_recv_sock() and tcp_v6_syn_recv_sock() call them
> for new sock, so delete redundant calls of them.
>
> Weiping Pan (2):
> tcp: delete redundant calls of tcp_mtup_init()
> tcp: delete redundant call of tcp_initialize_rcv_mss()
I do not agree with the approach of these two patches.
It is better to have tcp_rcv_state_process() (one location) make these
calls rather than each and every inet sock operations instance.
Therefore you should remove the calls from tcp_v{4,6}_recv_sock() and
keep the one in tcp_rcv_state_process().
Thanks.
next prev parent reply other threads:[~2014-01-15 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 7:54 [PATCH net 0/2] tcp: delete redundant calls of tcp_mtup_init() and Weiping Pan
2014-01-12 7:54 ` [PATCH net 1/2] tcp: delete redundant calls of tcp_mtup_init() Weiping Pan
2014-01-12 7:54 ` [PATCH net 2/2] tcp: delete redundant call of tcp_initialize_rcv_mss() Weiping Pan
2014-01-15 0:41 ` David Miller [this message]
2014-01-19 12:44 ` [PATCH net v2] tcp: delete redundant calls of tcp_mtup_init() Weiping Pan
2014-01-22 0:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114.164105.524133214769947013.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=panweiping3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).