From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org
Subject: Re: [ PATCH net-next] qlcnic: fix sparse warnings
Date: Sat, 18 Jan 2014 23:09:24 -0800 (PST) [thread overview]
Message-ID: <20140118.230924.161581406065831782.davem@davemloft.net> (raw)
In-Reply-To: <20140118172113.16adb69f@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Sat, 18 Jan 2014 17:21:13 -0800
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> Previous patch changed prototypes, but forgot functions.
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
> ---
> qlcnic_83xx_hw.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c 2014-01-18 13:41:07.000000000 -0800
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c 2014-01-18 17:13:08.640658697 -0800
> @@ -2066,7 +2066,7 @@ void qlcnic_83xx_change_l2_filter(struct
> qlcnic_83xx_sre_macaddr_change(adapter, mac, vlan_id, QLCNIC_MAC_ADD);
> }
>
> -void qlcnic_83xx_configure_mac(struct qlcnic_adapter *adapter, u8 *mac,
> +static void qlcnic_83xx_configure_mac(struct qlcnic_adapter *adapter, u8 *mac,
> u8 type, struct qlcnic_cmd_args *cmd)
Please adjust argument indentation, this goes for the whole patch.
Thanks.
next prev parent reply other threads:[~2014-01-19 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 1:21 [ PATCH net-next] qlcnic: fix sparse warnings Stephen Hemminger
2014-01-19 7:09 ` David Miller [this message]
2014-01-19 19:37 ` [ PATCH net-next vw] " Stephen Hemminger
2014-01-20 3:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140118.230924.161581406065831782.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).