From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/7] sctp: remove some macro locking wrappers Date: Tue, 21 Jan 2014 18:42:29 -0800 (PST) Message-ID: <20140121.184229.116401257671728929.davem@davemloft.net> References: <1390290252-16080-1-git-send-email-wangweidong1@huawei.com> <52DE8F39.30902@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: wangweidong1@huawei.com, nhorman@tuxdriver.com, dborkman@redhat.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org To: vyasevich@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:39389 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440AbaAVCma (ORCPT ); Tue, 21 Jan 2014 21:42:30 -0500 In-Reply-To: <52DE8F39.30902@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vlad Yasevich Date: Tue, 21 Jan 2014 10:16:09 -0500 > On 01/21/2014 02:44 AM, Wang Weidong wrote: >> In sctp.h we can find some macro locking wrappers. As Neil point out that: >> >> "Its because in the origional implementation of the sctp protocol, there was a >> user space test harness which built the kernel module for userspace execution to >> cary our some unit testing on the code. It did so by redefining some of those >> locking macros to user space friendly code. IIRC we haven't use those unit >> tests in years, and so should be removing them, not adding them to other >> locations." >> >> So I remove them. >> >> Wang Weidong (7): >> sctp: remove macro sctp_spin_[un]lock_irqrestore >> sctp: remove macro sctp_local_bh_{disable|enable} >> sctp: remove macro sctp_spin_[un]lock >> sctp: remove macros sctp_write_[un]_lock >> sctp: remove macros sctp_read_[un]lock >> sctp: remove macros sctp_{lock|release}_sock >> sctp: remove macros sctp_bh_[un]lock_sock >> >> include/net/sctp/sctp.h | 27 ++----------- >> net/sctp/endpointola.c | 4 +- >> net/sctp/input.c | 54 +++++++++++++------------- >> net/sctp/proc.c | 12 +++--- >> net/sctp/protocol.c | 4 +- >> net/sctp/sm_sideeffect.c | 16 ++++---- >> net/sctp/socket.c | 98 ++++++++++++++++++++++++------------------------ >> 7 files changed, 98 insertions(+), 117 deletions(-) >> > > I like this series just the way it is. Very simple to review. > > Series > Acked-by: Vlad Yasevich I had to append the DLM fix (since it used the sctp_*() interfaces) to patch #6, otherwise it would have broken bisection. Series applied, thanks.