From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Julian Anastasov <ja@ssi.bg>
Cc: gregory hoggarth <gregory.hoggarth@alliedtelesis.co.nz>,
netdev@vger.kernel.org
Subject: Re: Linux kernel patch: elide fib_validate_source() completely when possible - bad side effect?
Date: Thu, 23 Jan 2014 03:02:24 +0100 [thread overview]
Message-ID: <20140123020224.GG7269@order.stressinduktion.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1401222222010.1855@ja.home.ssi.bg>
On Wed, Jan 22, 2014 at 11:04:52PM +0200, Julian Anastasov wrote:
> I don't remember someone mentioning about such
> side-effect, I guess it is overlooked. IMHO, it is not a good
> reason to restore the old behavior. Lets see other opinions.
A routing lookup to check for broadcast is much too expansive, I agree. But
can't we just check skb->pkt_type == PACKET_BROADCAST?
Greetings,
Hannes
next prev parent reply other threads:[~2014-01-23 2:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 1:59 Linux kernel patch: elide fib_validate_source() completely when possible - bad side effect? gregory hoggarth
2014-01-17 8:24 ` Julian Anastasov
2014-01-19 20:49 ` gregory hoggarth
2014-01-22 21:04 ` Julian Anastasov
2014-01-23 2:02 ` Hannes Frederic Sowa [this message]
2014-01-23 2:06 ` Hannes Frederic Sowa
2014-01-23 2:53 ` David Miller
2014-01-23 3:03 ` Hannes Frederic Sowa
2014-01-23 9:47 ` Julian Anastasov
2014-01-23 14:20 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123020224.GG7269@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=gregory.hoggarth@alliedtelesis.co.nz \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).