netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fan Du <fan.du@windriver.com>
Cc: steffen.klassert@secunet.com, davem@davemloft.net,
	netdev <netdev@vger.kernel.org>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next] ipcomp: Convert struct xt_ipcomp spis into 16bits
Date: Wed, 19 Feb 2014 11:14:03 +0100	[thread overview]
Message-ID: <20140219101403.GA9160@localhost> (raw)
In-Reply-To: <52DC821E.3000309@windriver.com>

On Mon, Jan 20, 2014 at 09:55:42AM +0800, Fan Du wrote:
> On 2014年01月18日 20:24, Pablo Neira Ayuso wrote:
> >Didn't you find any way to fix this without change the layout of
> >xt_ipcomp?
> 
> My bad for not catching this in the initial ipcomp version.
> It would be easier to just use ntohs here to ease sparse checking.
> 
> 
> From dbf796e63d600256fd40000669b83227ddccebc4 Mon Sep 17 00:00:00 2001
> From: Fan Du <fan.du@windriver.com>
> Date: Mon, 20 Jan 2014 09:42:12 +0800
> Subject: [PATCHv2 net-next] ipcomp: Use ntohs to ease sparse warning
> 
> 0-DAY kernel build testing backend reported:
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> >> net/netfilter/xt_ipcomp.c:63:26: sparse: restricted __be16 degrades to integer
> >> >> net/netfilter/xt_ipcomp.c:63:26: sparse: cast to restricted __be32
> 
> Fix this by using ntohs without shifting.
> 
> Tested with: make C=1 CF=-D__CHECK_ENDIAN__

Applied to nf-next, thanks.

      reply	other threads:[~2014-02-19 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18  2:16 [PATCH net-next] ipcomp: Convert struct xt_ipcomp spis into 16bits Fan Du
2014-01-18 12:24 ` Pablo Neira Ayuso
2014-01-20  1:55   ` Fan Du
2014-02-19 10:14     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140219101403.GA9160@localhost \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fan.du@windriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).