From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: ast@plumgrid.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/9] BPF updates
Date: Mon, 31 Mar 2014 00:46:16 -0400 (EDT) [thread overview]
Message-ID: <20140331.004616.1557779324959569233.davem@davemloft.net> (raw)
In-Reply-To: <1396029506-16776-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 28 Mar 2014 18:58:17 +0100
> We sat down and have heavily reworked the whole previous patchset
> from v10 [1] to address all comments/concerns. This patchset therefore
> *replaces* the internal BPF interpreter with the new layout as
> discussed in [1], and migrates some exotic callers to properly use the
> BPF API for a transparent upgrade. All other callers that already use
> the BPF API in a way it should be used, need no further changes to run
> the new internals. We also removed the sysctl knob entirely, and do not
> expose any structure to userland, so that implementation details only
> reside in kernel space. Since we are replacing the interpreter we had
> to migrate seccomp in one patch along with the interpreter to not break
> anything. When attaching a new filter, the flow can be described as
> following: i) test if jit compiler is enabled and can compile the user
> BPF, ii) if so, then go for it, iii) if not, then transparently migrate
> the filter into the new representation, and run it in the interpreter.
> Also, we have scratched the jit flag from the len attribute and made it
> as initial patch in this series as Pablo has suggested in the last
> feedback, thanks. For details, please refer to the patches themselves.
>
> We did extensive testing of BPF and seccomp on the new interpreter
> itself and also on the user ABIs and could not find any issues; new
> performance numbers as posted in patch 8 are also still the same.
>
> Please find more details in the patches themselves.
>
> For all the previous history from v1 to v10, see [1]. We have decided
> to drop the v11 as we have pedantically reworked the set, but of course,
> included all previous feedback.
Ok, applied, thanks a lot everyone.
prev parent reply other threads:[~2014-03-31 4:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 17:58 [PATCH net-next v4 0/9] BPF updates Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 1/9] net: filter: add jited flag to indicate jit compiled filters Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 2/9] net: filter: keep original BPF program around Daniel Borkmann
2014-09-12 3:27 ` Eric Dumazet
2014-09-12 3:51 ` Alexei Starovoitov
2014-09-12 6:09 ` Daniel Borkmann
2014-09-13 21:05 ` David Miller
2014-03-28 17:58 ` [PATCH net-next v4 3/9] net: filter: move filter accounting to filter core Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 4/9] net: ptp: use sk_unattached_filter_create() for BPF Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 5/9] net: ptp: do not reimplement PTP/BPF classifier Daniel Borkmann
2014-03-31 9:13 ` Richard Cochran
2014-03-31 20:37 ` Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 6/9] net: ppp: use sk_unattached_filter api Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 7/9] net: isdn: " Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 8/9] net: filter: rework/optimize internal BPF interpreter's instruction set Daniel Borkmann
2014-03-28 17:58 ` [PATCH net-next v4 9/9] doc: filter: extend BPF documentation to document new internals Daniel Borkmann
2014-03-31 4:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331.004616.1557779324959569233.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@plumgrid.com \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).