netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pebolle@tiscali.nl
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arcnet: remove check for CONFIG_SA1100_CT6001
Date: Fri, 30 May 2014 17:26:15 -0700 (PDT)	[thread overview]
Message-ID: <20140530.172615.2243203796607511160.davem@davemloft.net> (raw)
In-Reply-To: <20140530.172109.1758735676902083194.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Fri, 30 May 2014 17:21:09 -0700 (PDT)

> From: Paul Bolle <pebolle@tiscali.nl>
> Date: Tue, 27 May 2014 21:53:44 +0200
> 
>> A check for CONFIG_SA1100_CT6001 was added in v2.6.11. But the related
>> Kconfig symbol was never added to the tree. Remove this check and do
>> some related cleaning up.
>> 
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> 
> Applied to net-next, thanks.

Reverted, you missed more references to BUS_ALIGN in com20020.c:

drivers/net/arcnet/com20020.c: In function ‘com20020_check’:
drivers/net/arcnet/com20020.c:120:22: error: ‘BUS_ALIGN’ undeclared (first use in this function)
drivers/net/arcnet/com20020.c:120:22: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/arcnet/com20020.c: In function ‘com20020_found’:
drivers/net/arcnet/com20020.c:182:35: error: ‘BUS_ALIGN’ undeclared (first use in this function)

For a driver that builds on x86, there is no excuse not to have at least
build tested this patch.

      reply	other threads:[~2014-05-31  0:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 19:53 [PATCH] arcnet: remove check for CONFIG_SA1100_CT6001 Paul Bolle
2014-05-31  0:21 ` David Miller
2014-05-31  0:26   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530.172615.2243203796607511160.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).