From: wenxiong@linux.vnet.ibm.com
To: Dmitry Kravkov <Dmitry.Kravkov@qlogic.com>
Cc: David Miller <davem@davemloft.net>,
Ariel Elior <Ariel.Elior@qlogic.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] bnx2x: Fix kernel crash and data miscompare after EEH recovery
Date: Tue, 03 Jun 2014 15:14:28 -0400 [thread overview]
Message-ID: <20140603151428.Horde.DYj0Npir309Tjh6U6PLlFFA@imap.linux.ibm.com> (raw)
In-Reply-To: <87B4DDAD5EAFA041BDC28F314593782D0174F4A8@avmb3.qlogic.org>
Quoting Dmitry Kravkov <Dmitry.Kravkov@qlogic.com>:
> On Jun 2, 2014 5:26 AM, David Miller <davem@davemloft.net> wrote:
>>
>> From: wenxiong@linux.vnet.ibm.com
>> Date: Wed, 28 May 2014 10:56:43 -0500
>>
>> > A rmb() is required to ensure that the CQE is not read before it
>> > is written by the adapter DMA. PCI ordering rules will make sure
>> > the other fields are written before the marker at the end of struct
>> > eth_fast_path_rx_cqe but without rmb() a weakly ordered processor can
>> > process stale data.
>> >
>> > Without the barrier we have observed various crashes including
>> > bnx2x_tpa_start being called on queues not stopped (resulting in message
>> > start of bin not in stop) and NULL pointer exceptions from bnx2x_rx_int.
>> >
>> > Signed-off-by: Milton Miller <miltonm@bga.com>
> Wen, are you sure the addressee is correct? Our mail server was
> unable to deliver.
I didn't see the failure when I submitted the patch. I checked with Milton.
The domain was sold recently.
Thanks,
Wendy
>
> ________________________________
>
> This message and any attached documents contain information from
> QLogic Corporation or its wholly-owned subsidiaries that may be
> confidential. If you are not the intended recipient, you may not
> read, copy, distribute, or use this information. If you have
> received this transmission in error, please notify the sender
> immediately by reply e-mail and then delete this message.
next parent reply other threads:[~2014-06-03 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87B4DDAD5EAFA041BDC28F314593782D0174F4A8@avmb3.qlogic.org>
2014-06-03 19:14 ` wenxiong [this message]
2014-05-28 15:56 [PATCH V2 0/2] Adapter not recovery from EEH error injection wenxiong
2014-05-28 15:56 ` [PATCH V2 2/2] bnx2x: Fix kernel crash and data miscompare after EEH recovery wenxiong
2014-05-28 19:23 ` Dmitry Kravkov
2014-05-29 14:50 ` wenxiong
2014-06-02 2:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603151428.Horde.DYj0Npir309Tjh6U6PLlFFA@imap.linux.ibm.com \
--to=wenxiong@linux.vnet.ibm.com \
--cc=Ariel.Elior@qlogic.com \
--cc=Dmitry.Kravkov@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).