From: Stephen Hemminger <stephen@networkplumber.org>
To: Christopher White <chris@logicalelegance.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] LISP: Locator/Identifier Separation Protocol
Date: Tue, 3 Jun 2014 15:16:21 -0700 [thread overview]
Message-ID: <20140603151621.2e4a73ba@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <E5B7A820-EF96-4F50-81F8-DE7714105D89@logicalelegance.com>
On Thu, 29 May 2014 14:05:29 -0700
Christopher White <chris@logicalelegance.com> wrote:
> +#define LISP_VERSION "0.1"
> +
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 36)
> +#define rt_dst(rt) (rt->dst)
> +#else
> +#define rt_dst(rt) (rt->u.dst)
> +#endif
> +
Upstream kernel submissions should never include kernel version
checks. Remove these and get rid of the wrapper.
next prev parent reply other threads:[~2014-06-03 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:05 [PATCH net-next] LISP: Locator/Identifier Separation Protocol Christopher White
2014-05-30 0:13 ` Tom Herbert
2014-05-30 15:07 ` Christopher White
2014-06-03 22:16 ` Stephen Hemminger [this message]
2014-06-03 22:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603151621.2e4a73ba@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=chris@logicalelegance.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).