From: David Miller <davem@davemloft.net>
To: octavian.purdila@intel.com
Cc: David.Laight@aculab.com, netdev@vger.kernel.org,
christoph.paasch@uclouvain.be, alex.bluesman.smirnov@gmail.com,
dbaryshkov@gmail.com, mareklindner@neomailbox.ch,
sw@simonwunderlich.de, antonio@meshcoding.com,
marcel@holtmann.org, gustavo@padovan.org,
johan.hedberg@gmail.com, arvid.brodin@alten.se, kaber@trash.net,
pablo@netfilter.org, kadlec@blackhole.kfki.hu,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
sameo@linux.intel.com, jon.maloy@ericsson.com,
allan.stephens@windriver.com, andrew.hendry@gmail.com,
edumazet@google.com
Subject: Re: [PATCH net-next v3] net: add skb allocation flags to pskb_copy
Date: Wed, 11 Jun 2014 12:09:14 -0700 (PDT) [thread overview]
Message-ID: <20140611.120914.1187135773039853303.davem@davemloft.net> (raw)
In-Reply-To: <CAE1zotKXQwk89QLmc-PWMO69qgUgTVmbQTbc2EzbTXCF61tyXw@mail.gmail.com>
From: Octavian Purdila <octavian.purdila@intel.com>
Date: Wed, 11 Jun 2014 12:59:26 +0300
> On Wed, Jun 11, 2014 at 12:22 PM, David Laight <David.Laight@aculab.com> wrote:
>> From: Octavian Purdila
>>> There are several instances where a pskb_copy or __pskb_copy is
>>> immediately followed by an skb_clone. Add a new parameter to allow the
>>> skb to be allocated from the fclone cache and thus speed up subsequent
>>> skb_clone calls.
>> ...
>>> @@ -2233,9 +2233,9 @@ static inline dma_addr_t skb_frag_dma_map(struct device *dev,
>>> }
>>>
>>> static inline struct sk_buff *pskb_copy(struct sk_buff *skb,
>>> - gfp_t gfp_mask)
>>> + gfp_t gfp_mask, bool fclone)
>>> {
>>> - return __pskb_copy(skb, skb_headroom(skb), gfp_mask);
>>> + return __pskb_copy(skb, skb_headroom(skb), gfp_mask, fclone);
>> ...
>>
>> Why not add:
>> static inline struct sk_buff *pskb_copy_for_clone(struct sk_buff *skb,
>> gfp_t gfp_mask)
>> {
>> return __pskb_copy(skb, skb_headroom(skb), gfp_mask, true);
>> }
>>
>> So that only some of the call sites need changing.
>> The different function name is probably easier to grok than a Boolean
>> parameter.
>>
>
> Hi David,
>
> Since cloning a copy seems to be more frequent then one would thought,
> I think that explicitly adding the option will force people to think
> about allocating from the fclone cache.
>
> But I don't care much either way, so if people think a new function is
> better I will rework the patch.
Actually you can do this in a way that makes the patch simpler.
Keep __pskb_copy()'s signature as is, and make it do something like:
__pskb_copy_clone(skb, gfp_mask, false);
And then make the aforementioned pskb_copy_for_clone() which is:
__pskb_copy_clone(skb, gfp_mask, true);
Then most of the call sites don't need to be touched at all. You only
change the ones that want the new semantics.
prev parent reply other threads:[~2014-06-11 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 9:12 [PATCH net-next v3] net: add skb allocation flags to pskb_copy Octavian Purdila
2014-06-11 9:22 ` David Laight
2014-06-11 9:59 ` Octavian Purdila
2014-06-11 19:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611.120914.1187135773039853303.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@aculab.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=allan.stephens@windriver.com \
--cc=aloisio.almeida@openbossa.org \
--cc=andrew.hendry@gmail.com \
--cc=antonio@meshcoding.com \
--cc=arvid.brodin@alten.se \
--cc=christoph.paasch@uclouvain.be \
--cc=dbaryshkov@gmail.com \
--cc=edumazet@google.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=marcel@holtmann.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pablo@netfilter.org \
--cc=sameo@linux.intel.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).