From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, anish@chelsio.com
Subject: Re: linux-next: build failure after merge of the net tree
Date: Tue, 16 Sep 2014 21:48:59 -0400 (EDT) [thread overview]
Message-ID: <20140916.214859.1906368469534009374.davem@davemloft.net> (raw)
In-Reply-To: <20140917110454.399a7841@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 17 Sep 2014 11:04:54 +1000
> This is a bit different to yesterday's failure but I assume it is still
> related to commit 5d6be6a5d486 ("scsi_netlink : Make SCSI_NETLINK
> dependent on NET instead of selecting NET").
>
> I used the net tree from next-20140915 again today.
Should be fixed by:
commit 6a38792ca8a5da28f65dc42eeb73d9a431f8d0fd
Author: Randy Dunlap <rdunlap@infradead.org>
Date: Tue Sep 16 13:47:41 2014 -0700
scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS
There are other kconfig symbols which use SCSI_FC_ATTRS.
In order to maintain sanity and prevent kconfig warnings, change
all of these from using 'select' to using 'depends on' so that
proper symbol dependencies will be honored and circular depends
problems will be avoided.
This fixes kconfig warnings and build errors:
warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC && SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first use in this function)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first use in this function)
Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig
index a34a11d..63ca984 100644
--- a/drivers/message/fusion/Kconfig
+++ b/drivers/message/fusion/Kconfig
@@ -29,7 +29,7 @@ config FUSION_SPI
config FUSION_FC
tristate "Fusion MPT ScsiHost drivers for FC"
depends on PCI && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
---help---
SCSI HOST support for a Fiber Channel host adapters.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 1d7e513..b745012 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -585,7 +585,7 @@ config HYPERV_STORAGE
config LIBFC
tristate "LibFC module"
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
select CRC32
---help---
Fibre Channel library module
@@ -816,7 +816,7 @@ config SCSI_IBMVSCSI
config SCSI_IBMVFC
tristate "IBM Virtual FC support"
depends on PPC_PSERIES && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
help
This is the IBM POWER Virtual FC Client
@@ -1266,7 +1266,7 @@ source "drivers/scsi/qla4xxx/Kconfig"
config SCSI_LPFC
tristate "Emulex LightPulse Fibre Channel Support"
depends on PCI && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
select CRC_T10DIF
help
This lpfc driver supports the Emulex LightPulse
@@ -1676,7 +1676,7 @@ config SCSI_SUNESP
config ZFCP
tristate "FCP host bus adapter driver for IBM eServer zSeries"
depends on S390 && QDIO && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
help
If you want to access SCSI devices attached to your IBM eServer
zSeries by means of Fibre Channel interfaces say Y.
@@ -1704,7 +1704,7 @@ config SCSI_PM8001
config SCSI_BFA_FC
tristate "Brocade BFA Fibre Channel Support"
depends on PCI && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
help
This bfa driver supports all Brocade PCIe FC/FCOE host adapters.
diff --git a/drivers/scsi/csiostor/Kconfig b/drivers/scsi/csiostor/Kconfig
index 4d03b03..7c7e508 100644
--- a/drivers/scsi/csiostor/Kconfig
+++ b/drivers/scsi/csiostor/Kconfig
@@ -1,7 +1,7 @@
config SCSI_CHELSIO_FCOE
tristate "Chelsio Communications FCoE support"
depends on PCI && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
select FW_LOADER
help
This driver supports FCoE Offload functionality over
diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 23d6072..7d65776 100644
--- a/drivers/scsi/qla2xxx/Kconfig
+++ b/drivers/scsi/qla2xxx/Kconfig
@@ -1,7 +1,7 @@
config SCSI_QLA_FC
tristate "QLogic QLA2XXX Fibre Channel Support"
depends on PCI && SCSI
- select SCSI_FC_ATTRS
+ depends on SCSI_FC_ATTRS
select FW_LOADER
---help---
This qla2xxx driver supports all QLogic Fibre Channel
next prev parent reply other threads:[~2014-09-17 1:48 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 1:04 linux-next: build failure after merge of the net tree Stephen Rothwell
2014-09-17 1:12 ` Stephen Rothwell
2014-09-17 1:48 ` David Miller [this message]
2014-09-17 2:18 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-04-10 22:42 Stephen Rothwell
2023-05-17 23:06 Stephen Rothwell
2023-05-17 23:29 ` Stephen Rothwell
2023-05-18 4:42 ` Jakub Kicinski
2023-05-18 6:47 ` Paolo Abeni
2023-05-18 6:52 ` Dario Binacchi
2023-05-18 7:14 ` Paolo Abeni
2023-05-18 9:37 ` Marc Kleine-Budde
2021-07-06 23:11 Stephen Rothwell
2021-07-08 4:01 ` Stephen Rothwell
2018-11-15 6:02 Stephen Rothwell
2017-06-08 0:08 Stephen Rothwell
2017-06-08 0:17 ` David Miller
2017-06-08 7:22 ` Greg Kroah-Hartman
2017-06-08 9:00 ` Stephen Rothwell
2017-02-13 22:12 Stephen Rothwell
2017-02-13 23:31 ` Alexei Starovoitov
2017-02-14 7:59 ` Joe Stringer
2017-02-14 6:35 ` Ingo Molnar
2017-02-14 6:42 ` Ingo Molnar
2017-02-14 9:19 ` Jiri Olsa
2017-02-14 12:50 ` Arnaldo Carvalho de Melo
2017-02-14 13:23 ` Jiri Olsa
2017-02-14 13:54 ` Arnaldo Carvalho de Melo
2017-02-16 3:02 ` Stephen Rothwell
2017-02-16 3:06 ` Alexei Starovoitov
2017-02-16 3:27 ` David Miller
2017-02-16 3:30 ` Alexei Starovoitov
2017-02-16 3:42 ` Stephen Rothwell
2016-10-20 22:27 Stephen Rothwell
2016-10-20 22:42 ` Florian Fainelli
2016-10-21 0:30 ` Florian Fainelli
2016-10-21 0:43 ` Stephen Rothwell
2016-10-21 0:46 ` Florian Fainelli
2014-10-14 23:44 Stephen Rothwell
2014-10-15 2:02 ` David Miller
2014-10-15 5:24 ` Giuseppe CAVALLARO
2014-09-16 0:24 Stephen Rothwell
2014-08-26 2:05 Stephen Rothwell
2014-08-26 3:22 ` David Miller
2014-08-26 3:33 ` Stephen Rothwell
2014-07-30 0:36 Stephen Rothwell
2014-07-30 8:26 ` Oliver Neukum
2014-07-04 1:39 Stephen Rothwell
2014-07-08 2:53 ` David Miller
2014-07-08 16:28 ` Florian Fainelli
2014-07-23 18:38 ` Vince Bridgers
2014-07-23 18:40 ` Florian Fainelli
2014-07-23 18:42 ` Vince Bridgers
2014-05-20 0:59 Stephen Rothwell
2014-05-20 14:50 ` Vlad Yasevich
2012-10-04 0:18 Stephen Rothwell
2012-10-04 0:50 ` David Miller
2012-10-04 1:06 ` Stephen Rothwell
2012-10-04 1:47 ` David Miller
2012-10-04 2:12 ` Jay Hernandez
2011-08-16 3:26 Stephen Rothwell
2011-08-16 4:03 ` David Miller
2011-08-12 2:02 Stephen Rothwell
2011-08-12 2:31 ` Jeff Kirsher
2011-08-12 2:51 ` David Miller
2011-08-12 3:05 ` Jeff Kirsher
2011-08-12 4:34 ` Stephen Rothwell
2011-08-12 5:22 ` Jeff Kirsher
2011-06-09 4:56 Stephen Rothwell
2011-06-09 5:17 ` Greg K-H
2011-06-09 5:39 ` Stephen Rothwell
2011-06-09 19:29 ` Greg KH
2011-06-10 20:28 ` Geert Uytterhoeven
2011-06-11 4:26 ` Stephen Rothwell
2011-06-11 11:39 ` Geert Uytterhoeven
2011-06-14 22:56 ` Stephen Rothwell
2011-06-20 4:58 ` Stephen Rothwell
2011-06-20 5:36 ` David Miller
2011-04-26 3:51 Stephen Rothwell
2011-04-26 19:43 ` David Miller
2011-04-13 2:03 Stephen Rothwell
2011-04-13 2:28 ` David Miller
2011-04-04 1:28 Stephen Rothwell
2011-04-04 2:43 ` David Miller
2011-03-14 4:24 Stephen Rothwell
2011-03-14 4:59 ` Ben Hutchings
2011-03-14 5:31 ` Stephen Rothwell
2011-03-14 5:53 ` David Miller
2011-03-14 6:05 ` Stephen Rothwell
2011-03-14 6:18 ` David Miller
2011-03-14 9:44 ` Thomas Gleixner
2011-03-14 9:56 ` Thomas Gleixner
2011-03-15 0:30 ` Stephen Rothwell
2011-03-15 4:07 ` David Miller
2011-03-15 6:25 ` Stephen Rothwell
2011-03-15 10:29 ` Thomas Gleixner
2011-03-15 22:07 ` David Miller
2011-03-09 2:42 Stephen Rothwell
2011-03-09 6:45 ` David Miller
2011-01-21 1:05 Stephen Rothwell
2011-01-21 1:10 ` David Miller
2010-12-09 2:28 Stephen Rothwell
2010-12-09 2:39 ` David Miller
2010-12-09 3:02 ` Stephen Rothwell
2010-12-07 1:00 Stephen Rothwell
2010-12-07 4:46 ` David Miller
2010-12-07 4:57 ` Joe Perches
2010-12-07 18:34 ` Breno Leitao
2010-11-29 0:08 Stephen Rothwell
2010-11-29 2:11 ` David Miller
2010-11-29 7:25 ` Peppe CAVALLARO
2010-11-16 0:34 Stephen Rothwell
2010-11-16 4:15 ` David Miller
2010-10-15 0:38 Stephen Rothwell
2010-10-14 22:07 ` Jeff Kirsher
2010-08-27 1:14 Stephen Rothwell
2010-08-27 3:32 ` David Miller
2010-06-15 2:00 Stephen Rothwell
2010-06-15 2:13 ` David Miller
2010-06-15 3:42 ` Stephen Rothwell
2010-05-03 2:08 Stephen Rothwell
2010-05-03 2:37 ` David Miller
2010-05-03 4:44 ` Stephen Rothwell
2010-04-07 2:58 Stephen Rothwell
2010-04-07 3:12 ` David Miller
2010-04-07 5:28 ` Stephen Rothwell
2010-02-15 4:20 Stephen Rothwell
2010-02-15 6:22 ` David Miller
2010-02-08 2:22 Stephen Rothwell
2010-02-08 3:40 ` David Miller
2010-02-08 3:58 ` Stephen Rothwell
2010-02-05 5:50 Stephen Rothwell
2010-02-05 6:32 ` David Miller
2010-02-05 11:49 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916.214859.1906368469534009374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anish@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).