From: David Miller <davem@davemloft.net>
To: Jiafei.Pan@freescale.com
Cc: jkosina@suse.cz, netdev@vger.kernel.org, LeoLi@freescale.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] net: use hardware buffer pool to allocate skb
Date: Wed, 15 Oct 2014 11:51:54 -0400 (EDT) [thread overview]
Message-ID: <20141015.115154.352769678083203819.davem@davemloft.net> (raw)
In-Reply-To: <c02005b9d8794d14bc2149f468ab571c@BY2PR03MB524.namprd03.prod.outlook.com>
From: "Jiafei.Pan@freescale.com" <Jiafei.Pan@freescale.com>
Date: Wed, 15 Oct 2014 05:34:24 +0000
> Yes, for this matter, in order to do this we should modify the Ethernet
> drivers. For example, driver A want to driver B, C, D.. to support driver
> A's Hardware block access functions, so we have to modify driver B, C, D...
> It will be so complex for this matter.
Experience says otherwise. It's three or four lines of code to attach
a page to an SKB frag.
The driver needs it's own buffer management and setup code anyways,
and no generic facility will replace that.
I think your precondition for these changes therefore doesn't really
exist.
Please, look over all of the drivers that exist already in the tree
and build SKBs using page frage from hardware device buffer pools.
You have to show us that all of those drivers can make use of your
facility.
next prev parent reply other threads:[~2014-10-15 15:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 3:26 [PATCH] net: use hardware buffer pool to allocate skb Pan Jiafei
2014-10-15 4:15 ` Eric Dumazet
2014-10-15 4:26 ` David Miller
2014-10-15 5:43 ` Jiafei.Pan
2014-10-15 9:15 ` Eric Dumazet
2014-10-15 4:25 ` David Miller
2014-10-15 5:34 ` Jiafei.Pan
2014-10-15 9:15 ` Eric Dumazet
2014-10-16 2:17 ` Jiafei.Pan
2014-10-16 4:15 ` Eric Dumazet
2014-10-16 5:15 ` Jiafei.Pan
2014-10-16 15:28 ` Alexander Duyck
2014-10-16 16:57 ` Eric Dumazet
2014-10-16 17:10 ` Alexander Duyck
2014-10-16 17:45 ` Eric Dumazet
2014-10-16 18:20 ` Alexander Duyck
2014-10-16 21:40 ` Eric Dumazet
2014-10-16 22:12 ` Alexander Duyck
2014-10-17 9:11 ` David Laight
2014-10-17 14:40 ` Alexander Duyck
2014-10-17 16:55 ` Eric Dumazet
2014-10-17 18:28 ` Alexander Duyck
2014-10-17 18:53 ` Eric Dumazet
2014-10-18 0:26 ` Eric Dumazet
2014-10-17 19:02 ` Eric Dumazet
2014-10-17 19:38 ` Alexander Duyck
2014-10-17 19:51 ` Eric Dumazet
2014-10-17 22:13 ` Alexander Duyck
2014-10-17 2:35 ` Jiafei.Pan
2014-10-17 14:05 ` Eric Dumazet
2014-10-17 14:12 ` Alexander Duyck
2014-10-16 2:17 ` Jiafei.Pan
2014-10-15 15:51 ` David Miller [this message]
2014-10-15 4:59 ` Oliver Hartkopp
2014-10-15 5:47 ` Jiafei.Pan
2014-10-15 8:57 ` David Laight
2014-10-15 9:33 ` Stephen Hemminger
2014-10-16 2:30 ` Jiafei.Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015.115154.352769678083203819.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jiafei.Pan@freescale.com \
--cc=LeoLi@freescale.com \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).