From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net 3/3] ipv4: clean up cookie_v4_check() Date: Fri, 17 Oct 2014 12:18:31 -0400 (EDT) Message-ID: <20141017.121831.1322788540924396350.davem@davemloft.net> References: <1413408802-21052-1-git-send-email-xiyou.wangcong@gmail.com> <1413408802-21052-3-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kkolasa@winsoft.pl, edumazet@google.com, cwang@twopensource.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:40823 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753156AbaJQQSd (ORCPT ); Fri, 17 Oct 2014 12:18:33 -0400 In-Reply-To: <1413408802-21052-3-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Wed, 15 Oct 2014 14:33:22 -0700 > From: Cong Wang > > We can retrieve opt from skb, no need to pass it as a parameter. > And opt should always be non-NULL, no need to check. > > Cc: Krzysztof Kolasa > Cc: Eric Dumazet > Tested-by: Krzysztof Kolasa > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang Applied.