From: Richard Cochran <richardcochran@gmail.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: David Miller <davem@davemloft.net>,
markos.chandras@imgtec.com, linux-mips@linux-mips.org,
corbet@lwn.net, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Foley <pefoley2@pefoley.com>
Subject: Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds
Date: Tue, 21 Oct 2014 20:27:57 +0200 [thread overview]
Message-ID: <20141021182757.GA3960@localhost.localdomain> (raw)
In-Reply-To: <544690CB.4030307@gmail.com>
(adding Makefile author Peter Foley onto CC)
On Tue, Oct 21, 2014 at 09:58:51AM -0700, David Daney wrote:
> On 10/21/2014 09:35 AM, David Miller wrote:
> >From: Richard Cochran <richardcochran@gmail.com>
> >Date: Tue, 21 Oct 2014 13:07:25 +0200
> >
> >>On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote:
> >>>diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile
> >>>index 293d6c09a11f..397c1cd2eda7 100644
> >>>--- a/Documentation/ptp/Makefile
> >>>+++ b/Documentation/ptp/Makefile
> >>>@@ -1,5 +1,15 @@
> >>> # List of programs to build
> >>>+ifndef CROSS_COMPILE
> >>> hostprogs-y := testptp
> >>>+else
> >>>+# MIPS system calls are defined based on the -mabi that is passed
> >>>+# to the toolchain which may or may not be a valid option
> >>>+# for the host toolchain. So disable testptp if target architecture
> >>>+# is MIPS but the host isn't.
> >>>+ifndef CONFIG_MIPS
> >>>+hostprogs-y := testptp
> >>>+endif
> >>>+endif
> >>
> >>It seems like a shame to simply give up and not compile this at all.
> >>Is there no way to correctly cross compile this for MIPS?
> >
> >Yeah seriously, we should try to make this work instead of throwing our
> >hands in the air.
> >
>
> We cross compile things successfully all the time for all the
> various MIPS ABIs.
>
> It is a simple matter of having the Makefile setup for cross compiling.
>
> What I don't understand is why we are using hostprogs in this
> Makefile. Isn't this a program that would run on the target, not
> the build host?
Yes.
Peter, could you please fix it?
Thanks,
Richard
next prev parent reply other threads:[~2014-10-21 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 8:42 [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds Markos Chandras
2014-10-21 11:07 ` Richard Cochran
2014-10-21 12:11 ` Markos Chandras
2014-10-21 12:52 ` Richard Cochran
2014-10-21 13:03 ` Markos Chandras
2014-10-21 13:39 ` Richard Cochran
2014-10-21 16:35 ` David Miller
2014-10-21 16:58 ` David Daney
2014-10-21 18:27 ` Richard Cochran [this message]
2014-10-21 22:04 ` Peter Foley
2014-10-22 8:03 ` Richard Cochran
2014-10-22 14:09 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021182757.GA3960@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ddaney.cavm@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=pefoley2@pefoley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).