From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] netlink: don't copy over empty attribute data Date: Wed, 22 Oct 2014 02:15:08 -0400 (EDT) Message-ID: <20141022.021508.2011745433893496421.davem@davemloft.net> References: <1413924669-26732-1-git-send-email-sasha.levin@oracle.com> <20141021.213908.1088381802543942481.davem@davemloft.net> <54471438.1040907@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: a.ryabinin@samsung.com, pablo@netfilter.org, mschmidt@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: sasha.levin@oracle.com Return-path: In-Reply-To: <54471438.1040907@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Sasha Levin Date: Tue, 21 Oct 2014 22:19:36 -0400 > On 10/21/2014 09:39 PM, David Miller wrote: >> From: Sasha Levin >> Date: Tue, 21 Oct 2014 16:51:09 -0400 >> >>> > netlink uses empty data to seperate different levels. However, we still >>> > try to copy that data from a NULL ptr using memcpy, which is an undefined >>> > behaviour. >>> > >>> > Signed-off-by: Sasha Levin >> This isn't a POSIX C library, this it the Linux kernel, and as such >> we can make sure none of our memcpy() implementations try to access >> any bytes if the given length is NULL. > > We can make *our* implementations work around that undefined behaviour if we > want, but right now our implementations is to call GCC's builtin memcpy(), > which follows the standards and doesn't allow you to call it with NULL 'from' > ptr. > > The fact that it doesn't die and behaves properly is just "luck". If GCC's internal memcpy() starts accessing past 'len', I'm going to report the bug rather than code around it. That causes a page fault, you _can't_ do it.