From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms" Date: Wed, 19 Nov 2014 11:45:42 +0300 Message-ID: <20141119084542.GK4905@mwanda> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAFF5.5020603@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Herbert Xu , Steffen Klassert , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle To: SF Markus Elfring Return-path: Content-Disposition: inline In-Reply-To: <546BAFF5.5020603@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Nov 18, 2014 at 09:45:41PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 21:41:26 +0100 > > The ipcomp_free_tfms() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > It doesn't though... regards, dan carpenter