From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc() Date: Fri, 5 Dec 2014 16:58:13 +0300 Message-ID: <20141205135813.GF4912@mwanda> References: <5317A59D.4@users.sourceforge.net> <547B4886.4080406@users.sourceforge.net> <547B496E.604@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> <5480DE25.2020802@users.sourceforge.net> <20141205122315.GC4912@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: SF Markus Elfring Return-path: Content-Disposition: inline In-Reply-To: <20141205122315.GC4912@mwanda> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Dec 05, 2014 at 03:23:15PM +0300, Dan Carpenter wrote: > On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 4 Dec 2014 22:42:30 +0100 > > > > The data structure element "sha1" was assigned a null pointer by the > > mppe_alloc() after a function call "crypto_alloc_hash" failed. > > This patch is also buggy. Actually it's ok. I was just confused by the changelog. Sorry about that, Markus. regards, dan carpenter