netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Hannes Frederic Sowa <hannes@redhat.com>
Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>
Subject: Re: ipv6: oops in datagram.c line 260
Date: Wed, 7 Jan 2015 13:26:07 +0100	[thread overview]
Message-ID: <20150107122607.GC13046@secunet.com> (raw)
In-Reply-To: <1420627502.26870.38.camel@redhat.com>

On Wed, Jan 07, 2015 at 11:45:02AM +0100, Hannes Frederic Sowa wrote:
> On Mi, 2015-01-07 at 08:22 +0100, Steffen Klassert wrote:
> > On Tue, Jan 06, 2015 at 05:01:13PM +0100, Hannes Frederic Sowa wrote:
> > > 
> > > xfrm6_output_finish unconditionally resets skb->protocol so we try to
> > > dispatch to the IPv6 handler, even though tcp just sends an IPv4 packet.
> > 
> > Maybe we better dispatch based on sk->sk_family, this should give
> > always the right address family of the socket.
> 
> The original problem was dealing with IPv4/v6 mapped traffic. Processing
> local errors from unconnected UDP sockets which are emitting both IPv4
> and IPv6 frames won't play nicely with sk->sk_family I fear.

Good point, unfortunately it is not so easy to fix as I thought.

  reply	other threads:[~2015-01-07 12:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  5:43 ipv6: oops in datagram.c line 260 Chris Ruehl
2014-12-24 13:42 ` Chris Ruehl
2015-01-06 16:01   ` Hannes Frederic Sowa
2015-01-07  7:22     ` Steffen Klassert
2015-01-07 10:45       ` Hannes Frederic Sowa
2015-01-07 12:26         ` Steffen Klassert [this message]
2015-01-26  8:35     ` Steffen Klassert
2015-01-27  4:20       ` Chris Ruehl
     [not found]       ` <54C71AFB.40300@gtsys.com.hk>
2015-01-27 11:58         ` Steffen Klassert
2015-01-28  3:50           ` Chris Ruehl
2015-02-06  7:37           ` Chris Ruehl
2015-02-10  9:57             ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107122607.GC13046@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=chris.ruehl@gtsys.com.hk \
    --cc=davem@davemloft.net \
    --cc=hannes@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).