netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: brytonlee01@gmail.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH] prevent the read ahead of /proc/slabinfo in ss
Date: Mon, 09 Feb 2015 11:16:18 -0800 (PST)	[thread overview]
Message-ID: <20150209.111618.1959932896181412008.davem@davemloft.net> (raw)
In-Reply-To: <1423481830-9599-1-git-send-email-brytonlee01@gmail.com>

From: Bryton Lee <brytonlee01@gmail.com>
Date: Mon,  9 Feb 2015 19:37:10 +0800

> @@ -617,6 +617,7 @@ struct slabstat
>  };
>  
>  struct slabstat slabstat;
> +int slabstat_valid = 0;
>  
>  static const char *slabstat_ids[] =
>  {

Nothing sets this to a non-zero value.  If nothing is going to set it to
a non-zero value, the code it guards should simple be removed instead.

Otherwise, nothing uses this variable outside of this file, and if
that's intentional it should be static.

  parent reply	other threads:[~2015-02-09 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 11:37 [PATCH] prevent the read ahead of /proc/slabinfo in ss Bryton Lee
2015-02-09 16:07 ` Eric Dumazet
2015-02-09 19:16 ` David Miller [this message]
2015-02-10  2:01   ` Bryton Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209.111618.1959932896181412008.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brytonlee01@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).