From: David Miller <davem@redhat.com>
To: makita.toshiaki@lab.ntt.co.jp
Cc: stephen@networkplumber.org, vyasevic@redhat.com,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] bridge: Fix inability to add non-vlan fdb entry
Date: Mon, 09 Feb 2015 14:19:21 -0800 (PST) [thread overview]
Message-ID: <20150209.141921.609350329551731658.davem@redhat.com> (raw)
In-Reply-To: <1423480577-9473-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Mon, 9 Feb 2015 20:16:17 +0900
> Bridge's default_pvid adds a vid by default, by which we cannot add a
> non-vlan fdb entry by default, because br_fdb_add() adds fdb entries for
> all vlans instead of a non-vlan one when any vlan is configured.
>
> # ip link add br0 type bridge
> # ip link set eth0 master br0
> # bridge fdb add 12:34:56:78:90:ab dev eth0 master temp
> # bridge fdb show brport eth0 | grep 12:34:56:78:90:ab
> 12:34:56:78:90:ab dev eth0 vlan 1 static
>
> We expect a non-vlan fdb entry as well as vlan 1:
> 12:34:56:78:90:ab dev eth0 static
>
> To fix this, we need to insert a non-vlan fdb entry if vlan is not
> specified, even when any vlan is configured.
>
> Fixes: 5be5a2df40f0 ("bridge: Add filtering support for default_pvid")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Applied.
prev parent reply other threads:[~2015-02-09 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 11:16 [PATCH net] bridge: Fix inability to add non-vlan fdb entry Toshiaki Makita
2015-02-09 22:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209.141921.609350329551731658.davem@redhat.com \
--to=davem@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).