netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: chien.yen@oracle.com, rds-devel@oss.oracle.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] rds: rds_cong_queue_updates needs to defer the congestion update transmission
Date: Wed, 11 Feb 2015 14:36:10 -0800 (PST)	[thread overview]
Message-ID: <20150211.143610.1232446952245428061.davem@davemloft.net> (raw)
In-Reply-To: <20150210183337.GX337@oracle.com>

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Tue, 10 Feb 2015 13:33:37 -0500

> 
> When the RDS transport is TCP, we cannot inline the call to rds_send_xmit
> from rds_cong_queue_update because
> (a) we are already holding the sock_lock in the recv path, and
>     will deadlock when tcp_setsockopt/tcp_sendmsg try to get the sock
>     lock
> (b) cong_queue_update does an irqsave on the rds_cong_lock, and this
>     will trigger warnings (for a good reason) from functions called
>     out of sock_lock.
> 
> This patch reverts the change introduced by
> 2fa57129d ("RDS: Bypass workqueue when queueing cong updates").
> 
> The patch has been verified for both RDS/TCP as well as RDS/RDMA
> to ensure that there are not regressions for either transport:
>  - for verification of  RDS/TCP a client-server unit-test was used,
>    with the server blocked in gdb and thus unable to drain its rcvbuf,
>    eventually triggering a RDS congestion update.
>  - for RDS/RDMA, the standard IB regression tests were used
> 
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>

Applied.

      reply	other threads:[~2015-02-11 22:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 18:33 [PATCHv2] rds: rds_cong_queue_updates needs to defer the congestion update transmission Sowmini Varadhan
2015-02-11 22:36 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150211.143610.1232446952245428061.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chien.yen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=sowmini.varadhan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).