From: David Miller <davem@davemloft.net>
To: maheshb@google.com
Cc: j.vosburgh@gmail.com, andy@greyhouse.net, vfalico@gmail.com,
nikolay@redhat.com, maze@google.com, netdev@vger.kernel.org,
edumazet@google.com
Subject: Re: [PATCH net-next v1] bonding: cosmetic/readability changes for admin, oper-key ops
Date: Mon, 06 Apr 2015 17:01:06 -0400 (EDT) [thread overview]
Message-ID: <20150406.170106.811076629093466625.davem@davemloft.net> (raw)
In-Reply-To: <1428094440-9241-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Fri, 3 Apr 2015 13:54:00 -0700
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
This is a very low quality patch submission.
You aren't explaining what you are really doing, or why.
Furthermore:
> @@ -1756,8 +1758,6 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
> port->actor_system_priority = 0xffff;
> port->actor_port_aggregator_identifier = 0;
> port->ntt = false;
> - port->actor_admin_port_key = 1;
> - port->actor_oper_port_key = 1;
> port->actor_admin_port_state = AD_STATE_AGGREGATION |
> AD_STATE_LACP_ACTIVITY;
> port->actor_oper_port_state = AD_STATE_AGGREGATION |
This is not just a readability or cosmetic change, it is changing behavior.
You need to describe why removing these initializers is valid, and also
this change is outside of the scope of a cosmetic/readability change so
would need to be split into another patch.
It is almost never correct to have an empty commit log message, espcially
when real changes are being made to the code as is happening here in this
code block.
next prev parent reply other threads:[~2015-04-06 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 20:54 [PATCH net-next v1] bonding: cosmetic/readability changes for admin, oper-key ops Mahesh Bandewar
2015-04-06 21:01 ` David Miller [this message]
2015-04-07 18:08 ` Mahesh Bandewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406.170106.811076629093466625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).