From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org, dmitry.tarnyaginuug.ch@6wind.com
Subject: Re: [PATCH net 0/3] netlink: fix wrong use of the flag NLM_F_MULTI
Date: Wed, 29 Apr 2015 15:00:15 -0400 (EDT) [thread overview]
Message-ID: <20150429.150015.854202938628093066.davem@davemloft.net> (raw)
In-Reply-To: <1430238831-29966-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Tue, 28 Apr 2015 18:33:47 +0200
> The first three patches fix a wrong use of this flag.
>
> Because it's not the first time that this kind of bug happens, it could be
> good to find something to help people.
>
> The only idea that I have is in the last patch. It's just an example, if
> people agrees on it, I will update all users and submit it formally.
> Any better idea is welcomed.
I've applied this series.
The only thing with patch #4 is that we have to make sure everyone
initializes all fields. It would be nice if there were a way to
sort-of enforce that.
Even just having a static inline initializer helper func might be
enough, like I added for nf_hook_info.
prev parent reply other threads:[~2015-04-29 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 16:33 [PATCH net 0/3] netlink: fix wrong use of the flag NLM_F_MULTI Nicolas Dichtel
2015-04-28 16:33 ` [PATCH net 1/3] bridge/mdb: remove wrong use of NLM_F_MULTI Nicolas Dichtel
2015-04-28 16:33 ` [PATCH net 2/3] bridge/nl: " Nicolas Dichtel
2015-04-30 13:01 ` Jeff Kirsher
2015-04-28 16:33 ` [PATCH net 3/3] tipc: " Nicolas Dichtel
2015-04-28 16:33 ` [RFC PATCH net 4/4] netlink: add a flags field in the cb structure Nicolas Dichtel
2015-04-29 19:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429.150015.854202938628093066.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry.tarnyaginuug.ch@6wind.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).