From: "John W. Linville" <linville@tuxdriver.com>
To: Cong Wang <cwang@twopensource.com>
Cc: netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jesse Gross <jesse@nicira.com>, Andy Zhou <azhou@nicira.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>
Subject: Re: [PATCH 5/5] geneve: add initial netdev driver for GENEVE tunnels
Date: Fri, 8 May 2015 19:22:36 -0400 [thread overview]
Message-ID: <20150508232236.GO14981@tuxdriver.com> (raw)
In-Reply-To: <CAHA+R7MqO2te-OR7mZqdy=TDkrcgyGhb-A4DvbQ07JAaKu49-Q@mail.gmail.com>
On Fri, May 08, 2015 at 01:55:15PM -0700, Cong Wang wrote:
> On Fri, May 8, 2015 at 10:20 AM, John W. Linville
> <linville@tuxdriver.com> wrote:
> > +
> > +/* Setup stats when device is created */
> > +static int geneve_init(struct net_device *dev)
> > +{
> > + struct geneve_dev *geneve = netdev_priv(dev);
> > +
> > + dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
> > + if (!dev->tstats)
> > + return -ENOMEM;
> > +
> > + /* make new socket outside of RTNL */
> > + dev_hold(dev);
> > + queue_work(geneve_wq, &geneve->sock_work);
> > +
>
>
> Any reason to create socket in this init() rather than in ndo_open()?
The socket can be created asynchronously and ndo_open can fail if
the socket creation hasn't succeeded.
> > + return 0;
> > +}
> > +
> > +static void geneve_uninit(struct net_device *dev)
> > +{
> > + struct geneve_dev *geneve = netdev_priv(dev);
> > + struct geneve_sock *gs = geneve->sock;
> > +
> > + if (gs)
> > + geneve_sock_release(gs);
> > + free_percpu(dev->tstats);
> > +}
>
>
> Ditto, ndo_stop().
I really don't see the point of the ndo_open/ndo_stop inquiry.
The socket creation seems analagous to device initialization to me.
> > +
> > +static int geneve_newlink(struct net *net, struct net_device *dev,
> > + struct nlattr *tb[], struct nlattr *data[])
> > +{
> ...
> > +
> > + if (data[IFLA_GENEVE_REMOTE])
> > + geneve->remote.sin_addr.s_addr =
> > + nla_get_be32(data[IFLA_GENEVE_REMOTE]);
>
>
> nla_get_in_addr()
The implementation of that is (not surprisingly) exactly the same
as nla_get_be32. I'll take it under advisement for a later patch,
but I don't really think a purely cosmetic change should interfere
with getting this merged.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2015-05-08 23:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 17:20 [PATCH] add GENEVE netdev tunnel driver John W. Linville
2015-05-08 17:20 ` [PATCH 1/5] geneve: remove MODULE_ALIAS_RTNL_LINK from net/ipv4/geneve.c John W. Linville
2015-05-08 17:20 ` [PATCH 2/5] geneve: move definition of geneve_hdr() to geneve.h John W. Linville
2015-05-08 17:20 ` [PATCH 3/5] geneve: Rename support library as geneve_core John W. Linville
2015-05-08 17:20 ` [PATCH 4/5] geneve_core: identify as driver library in modules description John W. Linville
2015-05-08 17:20 ` [PATCH 5/5] geneve: add initial netdev driver for GENEVE tunnels John W. Linville
2015-05-08 20:55 ` Cong Wang
2015-05-08 23:22 ` John W. Linville [this message]
2015-05-10 23:48 ` David Miller
2015-05-11 15:17 ` John W. Linville
2015-05-08 23:19 ` Jesse Gross
2015-05-11 20:51 ` [PATCH v2 " John W. Linville
2015-05-13 3:06 ` David Miller
2015-05-13 16:53 ` John W. Linville
2015-05-08 17:27 ` [PATCH] iproute2: GENEVE support John W. Linville
2015-05-08 23:27 ` Jesse Gross
2015-05-11 18:47 ` [PATCH v2] " John W. Linville
2015-05-08 19:32 ` [PATCH] add GENEVE netdev tunnel driver Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508232236.GO14981@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=alexander.h.duyck@redhat.com \
--cc=azhou@nicira.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).