netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: claudiu.manoil@freescale.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] gianfar: Move TxFIFO underrun handling to reset path
Date: Sat, 09 May 2015 17:37:56 -0400 (EDT)	[thread overview]
Message-ID: <20150509.173756.121159914986189798.davem@davemloft.net> (raw)
In-Reply-To: <1430924850-2871-1-git-send-email-claudiu.manoil@freescale.com>

From: Claudiu Manoil <claudiu.manoil@freescale.com>
Date: Wed, 6 May 2015 18:07:29 +0300

> Handle TxFIFO underrun exceptions outside the fast path.
> A controller reset is more reliable in this exceptional
> case, as opposed to re-enabling on-the-fly the Tx DMA.
> 
> As the controller reset is handled outside the fast path
> by the reset_gfar() workqueue handler, the locking
> scheme on the Tx path is significantly simplified.
> Because the Tx processing (xmit queues and tx napi) is
> disabled during controller reset, tstat access from xmit
> does not require locking.  So the scope of the txlock on
> the processing path is now reduced to num_txbdfree, which
> is shared only between process context (xmit) and softirq
> (clean_tx_ring).  As a result, the txlock must not guard
> against interrupt context, and the spin_lock_irqsave()
> from xmit can be replaced by spin_lock_bh().  Likewise,
> the locking has been downgraded for clean_tx_ring().
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>

Applied.

      parent reply	other threads:[~2015-05-09 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 15:07 [PATCH net-next 1/2] gianfar: Move TxFIFO underrun handling to reset path Claudiu Manoil
2015-05-06 15:07 ` [PATCH net-next 2/2] gianfar: Enable changing mac addr when if up Claudiu Manoil
2015-05-09 21:38   ` David Miller
2015-05-09 21:37 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150509.173756.121159914986189798.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=claudiu.manoil@freescale.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).