netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: pull-request: mac80211-next 2015-05-06
Date: Mon, 11 May 2015 10:41:02 -0400 (EDT)	[thread overview]
Message-ID: <20150511.104102.520345911968274714.davem@davemloft.net> (raw)
In-Reply-To: <1431333103.1964.4.camel@sipsolutions.net>

From: Johannes Berg <johannes@sipsolutions.net>
Date: Mon, 11 May 2015 10:31:43 +0200

> On Sat, 2015-05-09 at 17:34 -0400, David Miller wrote:
> 
>> Johhannes, the hash table size Kconfig entry absolutely not appropriate.
>> 
>> If anything, it should be hidden behind the strongest possible "DEBUG
>> ONLY" type dependencies, so that the user is never prompted for this
>> confusing option.
> 
> Hmm. It's hidden behind "MAC80211_DEBUG_MENU", which already should be
> discouragement, there's nothing in there that the user should ever
> select unless they're developing/debugging on this.
> 
> I can word the help text more strongly, perhaps? Or make the debug menu
> also depend on CONFIG_EXPERT (but most people seem to set that
> anyway ...)?
> 
> I'm happy to change this, but am not entirely sure how to discourage its
> use any further than we already do. Any suggestions?

Ok, this is actually my bad.

I keep forgetting that by doing allmodconfig builds all the time, I get
the debug options too. :-)

      reply	other threads:[~2015-05-11 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 13:59 pull-request: mac80211-next 2015-05-06 Johannes Berg
2015-05-06 14:02 ` Johannes Berg
     [not found]   ` <1430920954.1954.11.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-05-09 21:28     ` David Miller
2015-05-09 21:34       ` David Miller
     [not found]         ` <20150509.173446.1826713590855601099.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-05-11  8:31           ` Johannes Berg
2015-05-11 14:41             ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511.104102.520345911968274714.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).