From: David Miller <davem@davemloft.net>
To: kys@microsoft.com
Cc: joe@perches.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com
Subject: Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host
Date: Mon, 11 May 2015 10:41:21 -0400 (EDT) [thread overview]
Message-ID: <20150511.104121.111988027007099988.davem@davemloft.net> (raw)
In-Reply-To: <BY2PR0301MB0711C1248DF6677217A310BCA0DB0@BY2PR0301MB0711.namprd03.prod.outlook.com>
From: KY Srinivasan <kys@microsoft.com>
Date: Mon, 11 May 2015 08:59:53 +0000
>
>
>> -----Original Message-----
>> From: Joe Perches [mailto:joe@perches.com]
>> Sent: Sunday, May 10, 2015 10:58 PM
>> To: KY Srinivasan
>> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
>> apw@canonical.com; jasowang@redhat.com
>> Subject: Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to
>> optimize signaling the host
>>
>> On Sun, 2015-05-10 at 21:08 -0700, K. Y. Srinivasan wrote:
>> > Based on the information given to this driver (via the xmit_more skb flag),
>> > we can defer signaling the host if more packets are on the way. This will
>> help
>> > make the host more efficient since it can potentially process a larger batch
>> of
>> > packets. Implement this optimization.
>>
>> trivia:
>>
>> I think that indirecting
>> VMBUS_DATA_PACKET_FLAG_COMPLETTION_REQUESTED
>> into a non-const temporary isn't very useful.
>>
>> Whenever overly long identifiers like VMBUS_<FOO> is used,
>> I think that it'd be better to use it directly and ignore
>> 80 column warnings.
>
> Thanks Joe; if Dave agrees, I can send v6 of this patch out.
Sure, respin a v6.
prev parent reply other threads:[~2015-05-11 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 4:08 [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host K. Y. Srinivasan
2015-05-11 5:58 ` Joe Perches
2015-05-11 8:59 ` KY Srinivasan
2015-05-11 14:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511.104121.111988027007099988.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).