netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: daniel@iogearbox.net, ast@plumgrid.com, jhs@mojatatu.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] handle_ing update
Date: Mon, 11 May 2015 11:09:49 -0400 (EDT)	[thread overview]
Message-ID: <20150511.110949.1369224056076525434.davem@davemloft.net> (raw)
In-Reply-To: <20150510170550.GA4442@salvia>

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Sun, 10 May 2015 19:05:50 +0200

> On Sat, May 09, 2015 at 10:51:30PM +0200, Daniel Borkmann wrote:
>> These are a couple of cleanups to make ingress a bit more lightweight.
> 
> This is plain wrong at many levels.
> 
> You're persisting on embedding the ingress code into the core, and you
> have to remember that most users don't need this. Modules allows
> people to get the code that they need into the core, with this
> approach, they have no other choice other than disable from .config
> this if they don't need it.
> 
> This has to be done the other way around. I just sent a patchset to
> clean up this that in exactly the other direction, as a result,
> performance is improved for users that don't need this.
> 
> We should do things to make users aware that when they request
> features, they have to pay a performance cost, and that happens by
> when you invoke:
> 
>         tc qdisc add dev eth0 handle ffff: ingress
> 
> David already stated before that ingress path is performance critical,
> but you insist on trying to get qdisc ingress faster *at any cost*.

Pablo I think you are overreacting here.

What Daniel and Alexei are doing here is quite reasonable.

There is no difference between having ingress qdisc hanging off of
netdevice vs. the classifier list.  They both serve the same purpose
and the change to use the classifier list merely removes one level
of indirection.

I also am confident that the cost for non-users is equivalent before
and after this patch series.  Or at least, it very much should be.

Therefore I am going to apply these patches, and I wish you would work
more closely with Daniel and Alexei because I am more than convinced
that you share the same exact goals.

Thanks.

  parent reply	other threads:[~2015-05-11 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 20:51 [PATCH net-next 0/2] handle_ing update Daniel Borkmann
2015-05-09 20:51 ` [PATCH net-next 1/2] net: sched: consolidate handle_ing and ing_filter Daniel Borkmann
2015-05-09 21:07   ` Alexei Starovoitov
2015-05-09 20:51 ` [PATCH net-next 2/2] net: sched: further simplify handle_ing Daniel Borkmann
2015-05-10 17:05 ` [PATCH net-next 0/2] handle_ing update Pablo Neira Ayuso
2015-05-10 17:55   ` Alexei Starovoitov
2015-05-10 18:06     ` Pablo Neira Ayuso
2015-05-11 15:09   ` David Miller [this message]
2015-05-11 22:03     ` Cong Wang
2015-05-11 22:23       ` Alexei Starovoitov
2015-05-11 22:42         ` Cong Wang
2015-05-11 22:33       ` Daniel Borkmann
2015-05-11 22:48         ` Cong Wang
2015-05-12 12:54     ` Pablo Neira Ayuso
2015-05-11 15:11 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150511.110949.1369224056076525434.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ast@plumgrid.com \
    --cc=daniel@iogearbox.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).