From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next 15/15] tc: introduce Flower classifier Date: Mon, 11 May 2015 14:39:58 +0200 Message-ID: <20150511123958.GB2245@nanopsycho> References: <1431177038-11555-1-git-send-email-jiri@resnulli.us> <1431177038-11555-16-git-send-email-jiri@resnulli.us> <55509BC2.2090702@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, tgraf@suug.ch, jesse@nicira.com, kaber@trash.net, therbert@google.com, edumazet@google.com, alexander.h.duyck@redhat.com, hannes@stressinduktion.org, ast@plumgrid.com, daniel@iogearbox.net, herbert@gondor.apana.org.au, cwang@twopensource.com, john.fastabend@gmail.com To: Jamal Hadi Salim Return-path: Received: from mail-wi0-f182.google.com ([209.85.212.182]:37877 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbbEKMkG (ORCPT ); Mon, 11 May 2015 08:40:06 -0400 Received: by widdi4 with SMTP id di4so94704130wid.0 for ; Mon, 11 May 2015 05:40:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55509BC2.2090702@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: Mon, May 11, 2015 at 02:08:34PM CEST, jhs@mojatatu.com wrote: >On 05/09/15 09:10, Jiri Pirko wrote: >>This patch introduces a flow-based filter. So far, the very essential >>packet fields are supported. >> >>This patch is only the first step. There is a lot of potential performance >>improvements possible to implement. Also a lot of features are missing >>now. They will be addressed in follow-up patches. >> >>Signed-off-by: Jiri Pirko > >I have a question Jiri: What kind of flower is this? ;-> Just a generic flower :) >Very nice - Glad Dave pushed you to go this direction. >For a usable classifier that performs reasonably well, i think >this one is going to look good. > >My suggestion is to not add TCA_FLOWER_POLICE attribute. >Policers can be added via TCA_FLOWER_ACT (which is the modern >way to do it). Infact i would suggest even in your iproute2 >code, please kill the conditional that tries to parse for >TCA_FLOWER_POLICE > >Other than that: >Acked-by: Jamal Hadi Salim Okay, thanks. Will send v2 without TCA_FLOWER_POLICE.