From: David Miller <davem@davemloft.net>
To: david.ward@ll.mit.edu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net_sched: gred: add TCA_GRED_LIMIT attribute
Date: Tue, 12 May 2015 18:23:11 -0400 (EDT) [thread overview]
Message-ID: <20150512.182311.1437113579733139908.davem@davemloft.net> (raw)
In-Reply-To: <1431223307-26669-1-git-send-email-david.ward@ll.mit.edu>
From: David Ward <david.ward@ll.mit.edu>
Date: Sat, 9 May 2015 22:01:46 -0400
> In a GRED qdisc, if the default "virtual queue" (VQ) does not have drop
> parameters configured, then packets for the default VQ are not subjected
> to RED and are only dropped if the queue is larger than the net_device's
> tx_queue_len. This behavior is useful for WRED mode, since these packets
> will still influence the calculated average queue length and (therefore)
> the drop probability for all of the other VQs. However, for some drivers
> tx_queue_len is zero. In other cases the user may wish to make the limit
> the same for all VQs (including the default VQ with no drop parameters).
>
> This change adds a TCA_GRED_LIMIT attribute to set the GRED queue limit,
> in bytes, during qdisc setup. (This limit is in bytes to be consistent
> with the drop parameters.) The default limit is the same as for a bfifo
> queue (tx_queue_len * psched_mtu). If the drop parameters of any VQ are
> configured with a smaller limit than the GRED queue limit, that VQ will
> still observe the smaller limit instead.
>
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
Applied, thanks David.
prev parent reply other threads:[~2015-05-12 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 2:01 [PATCH net-next] net_sched: gred: add TCA_GRED_LIMIT attribute David Ward
2015-05-10 2:01 ` [PATCH] net_sched: gred: use correct backlog value in WRED mode David Ward
2015-05-12 22:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512.182311.1437113579733139908.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).