Hi all, Today's linux-next merge of the net-next tree got a conflict in include/net/codel.h between commit a5d280904050 ("codel: fix maxpacket/mtu confusion") from the net tree and commit 80ba92fa1a92 ("codel: add ce_threshold attribute") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au diff --cc include/net/codel.h index 1e18005f7f65,8c0f78f209e8..000000000000 --- a/include/net/codel.h +++ b/include/net/codel.h @@@ -119,14 -119,14 +119,16 @@@ static inline u32 codel_time_to_us(code /** * struct codel_params - contains codel parameters * @target: target queue size (in time units) + * @ce_threshold: threshold for marking packets with ECN CE * @interval: width of moving time window + * @mtu: device mtu, or minimal queue backlog in bytes. * @ecn: is Explicit Congestion Notification enabled */ struct codel_params { codel_time_t target; + codel_time_t ce_threshold; codel_time_t interval; + u32 mtu; bool ecn; }; @@@ -166,14 -167,16 +169,18 @@@ struct codel_stats u32 maxpacket; u32 drop_count; u32 ecn_mark; + u32 ce_mark; }; + #define CODEL_DISABLED_THRESHOLD INT_MAX + -static void codel_params_init(struct codel_params *params) +static void codel_params_init(struct codel_params *params, + const struct Qdisc *sch) { params->interval = MS2TIME(100); params->target = MS2TIME(5); + params->ce_threshold = CODEL_DISABLED_THRESHOLD; + params->mtu = psched_mtu(qdisc_dev(sch)); params->ecn = false; }