From: David Miller <davem@davemloft.net>
To: krisman@linux.vnet.ibm.com
Cc: mschmidt@redhat.com, Yuval.Mintz@qlogic.com,
LinoSanfilippo@gmx.de, Ariel.Elior@qlogic.com,
netdev@vger.kernel.org, cascardo@cascardo.eti.br,
brking@linux.vnet.ibm.com
Subject: Re: [PATCH] bnx2x: Alloc 4k fragment for each rx ring buffer element
Date: Mon, 01 Jun 2015 15:57:01 -0700 (PDT) [thread overview]
Message-ID: <20150601.155701.499463944154053931.davem@davemloft.net> (raw)
In-Reply-To: <87vbfeoteo.fsf_-_@sycorax.br.ibm.com>
From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Date: Wed, 27 May 2015 13:51:43 -0300
> Subject: [PATCH] bnx2x: Alloc 4k fragment for each rx ring buffer element
>
> The driver allocates one page for each buffer on the rx ring, which is
> too much on architectures like ppc64 and can cause unexpected allocation
> failures when the system is under stress. Now, we keep a memory pool
> per queue, and if the architecture's PAGE_SIZE is greater than 4k, we
> fragment pages and assign each 4k segment to a ring element, which
> reduces the overall memory consumption on such architectures. This
> helps avoiding errors like the example below:
>
> [bnx2x_alloc_rx_sge:435(eth1)]Can't alloc sge
> [c00000037ffeb900] [d000000075eddeb4] .bnx2x_alloc_rx_sge+0x44/0x200 [bnx2x]
> [c00000037ffeb9b0] [d000000075ee0b34] .bnx2x_fill_frag_skb+0x1ac/0x460 [bnx2x]
> [c00000037ffebac0] [d000000075ee11f0] .bnx2x_tpa_stop+0x160/0x2e8 [bnx2x]
> [c00000037ffebb90] [d000000075ee1560] .bnx2x_rx_int+0x1e8/0xc30 [bnx2x]
> [c00000037ffebcd0] [d000000075ee2084] .bnx2x_poll+0xdc/0x3d8 [bnx2x] (unreliable)
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
> Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
> Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
I think I've waited long enough on this, applied to net-next, thanks.
next prev parent reply other threads:[~2015-06-01 22:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 20:45 [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer element Gabriel Krisman Bertazi
2015-04-24 23:24 ` Lino Sanfilippo
2015-04-29 13:30 ` Gabriel Krisman Bertazi
2015-04-30 11:25 ` Yuval Mintz
2015-04-30 20:05 ` David Miller
2015-05-04 19:32 ` [PATCH v3] " Gabriel Krisman Bertazi
2015-05-04 19:58 ` Yuval Mintz
2015-05-15 20:43 ` Gabriel Krisman Bertazi
2015-05-17 7:14 ` Yuval Mintz
2015-05-21 13:20 ` [PATCH v4] " Gabriel Krisman Bertazi
2015-05-23 10:04 ` Yuval Mintz
2015-05-23 11:14 ` Lino Sanfilippo
2015-05-27 8:59 ` Michal Schmidt
2015-05-27 16:51 ` [PATCH] " Gabriel Krisman Bertazi
2015-06-01 22:57 ` David Miller [this message]
2015-05-28 7:24 ` [PATCH v4] " Yuval Mintz
2015-05-28 13:26 ` Gabriel Krisman Bertazi
-- strict thread matches above, loose matches on Subject: below --
2015-04-17 17:58 [PATCH] " Gabriel Krisman Bertazi
2015-04-19 15:48 ` Ariel Elior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601.155701.499463944154053931.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=LinoSanfilippo@gmx.de \
--cc=Yuval.Mintz@qlogic.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@cascardo.eti.br \
--cc=krisman@linux.vnet.ibm.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).