From: Jiri Pirko <jiri@resnulli.us>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
idosch@mellanox.com, eladr@mellanox.com,
"ogerlitz@mellanox.com" <ogerlitz@mellanox.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Thomas Graf <tgraf@suug.ch>,
Alexei Starovoitov <ast@plumgrid.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Daniel Borkmann <daniel@iogearbox.net>,
john fastabend <john.fastabend@gmail.com>,
"simon.horman@netronome.com" <simon.horman@netronome.com>,
John Linville <linville@tuxdriver.com>,
Andy Gospodarek <andy@greyhouse.net>,
Shrijeet Mukherjee <shm@cumulusnetworks.com>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support
Date: Sun, 26 Jul 2015 19:14:11 +0200 [thread overview]
Message-ID: <20150726171410.GB2207@nanopsycho.fritz.box> (raw)
In-Reply-To: <20150726071010.GA2150@nanopsycho.fritz.box>
<snip>
>
>
>>
>>> + struct sk_buff *skb_new;
>>> +
>>> + skb_new = skb_realloc_headroom(skb, MLXSW_TXHDR_LEN);
>>> + dev_kfree_skb_any(skb);
>>> + if (!skb_new) {
>>> + this_cpu_inc(mlxsw_sx_port->pcpu_stats->tx_dropped);
>>> + return NETDEV_TX_OK;
>>> + }
>>> + skb = skb_new;
>>> + }
>>> + mlxsw_sx_txhdr_construct(skb, &tx_info);
>>> + err = mlxsw_core_skb_transmit(mlxsw_sx, skb, &tx_info);
>>> + if (err == -EAGAIN)
>>> + return NETDEV_TX_BUSY;
>>
>>I think there is a problem here when returning NETDEV_TX_BUSY when
>>original skb might have been freed above in the headroom check. (ref
>>Documentation/networking/driver.txt).
>
>I have to check this out a bit more. Thanks for pointing that out.
You are right. In case queue is busy we obviously cannot free
the original skb. Will fix that in V2. Thanks!
next prev parent reply other threads:[~2015-07-26 17:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:43 [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Jiri Pirko
2015-07-23 15:43 ` [patch net-next 1/4] mlxsw: Introduce Mellanox switch driver core Jiri Pirko
2015-07-23 15:43 ` [patch net-next 2/4] mlxsw: Add PCI bus implementation Jiri Pirko
2015-07-24 4:52 ` Scott Feldman
2015-07-24 5:30 ` Jiri Pirko
2015-07-26 5:15 ` Scott Feldman
2015-07-26 6:49 ` Jiri Pirko
2015-07-23 15:43 ` [patch net-next 3/4] mlxsw: Add interface to access registers and process events Jiri Pirko
2015-07-23 21:12 ` Andy Gospodarek
2015-07-24 5:24 ` Jiri Pirko
2015-07-24 12:09 ` Andy Gospodarek
2015-07-24 5:13 ` Scott Feldman
2015-07-24 5:18 ` Jiri Pirko
2015-07-24 6:48 ` Elad Raz
2015-07-23 15:43 ` [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support Jiri Pirko
2015-07-23 17:19 ` Alexander Duyck
2015-07-23 19:42 ` Jiri Pirko
2015-07-26 2:45 ` Scott Feldman
2015-07-26 7:10 ` Jiri Pirko
2015-07-26 17:14 ` Jiri Pirko [this message]
2015-07-27 6:17 ` Rosen, Rami
2015-07-28 18:06 ` Jiri Pirko
2015-07-24 0:03 ` [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers Scott Feldman
2015-07-24 0:38 ` Rustad, Mark D
2015-07-24 5:38 ` Jiri Pirko
2015-07-27 6:51 ` David Miller
2015-07-27 20:21 ` Scott Feldman
2015-07-27 20:27 ` Jiri Pirko
2015-07-27 21:21 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726171410.GB2207@nanopsycho.fritz.box \
--to=jiri@resnulli.us \
--cc=andy@greyhouse.net \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=john.fastabend@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=shm@cumulusnetworks.com \
--cc=simon.horman@netronome.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).