netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: ????????? <xqjcool@gmail.com>
Cc: tadavis@lbl.gov, const-g@xpert.com, ctindel@ieee.org,
	girouard@us.ibm.com, fubar@us.ibm.com,
	mitch.a.williams@intel.com, buytenh@gnu.org,
	greearb@candelatech.com, netdev@vger.kernel.org, nick@dccinc.com,
	davem@redhat.com
Subject: Re: [PATCH][kernel 2.6.32] Bond interface can't send gratuitous ARP
Date: Mon, 27 Jul 2015 07:21:44 +0200	[thread overview]
Message-ID: <20150727052144.GB19418@1wt.eu> (raw)
In-Reply-To: <CAOtoAkdAArhXQCWsFq6Gk2-rZudY819HEtOJNuJzGxL5zNiEcg@mail.gmail.com>

Hi Qingjie,

On Mon, Jul 27, 2015 at 09:05:29AM +0800, ????????? wrote:
> Hi,
> 
> Bond interface worked as Active-Backup mode.
> If the bond interface was added in bridge, then it's just a port of bridge.
> It doesn' have IP address.
> When bond slave changing, the current code "bond_send_gratuitous_arp"
> didn't take effect. It couldn't send gratuitous ARP.
> So I made a patch to fix this issue.
> 
> It's my first patch for kernel.
> 
> Thanks a lot for your *understanding* for any *inconvenience* caused.

Patches may only be sent for mainline kernel. Since you're trying to fix
2.6.32, you first need to check if a more recent version works properly.
If it's the case, then instead you should ask for a backport of the patch
that did the related change (it's easier for tracking bug fixes and
regressions). If the problem is also present in mainline, then you should
propose your patch for mainline. Since it's a fix, it will be backported.

BTW, please keep in mind that 2.6.32 is reaching EOL in a few months, so
it would be a good time to try newer ones (3.2 or 3.4 are rock solid now).

Hoping this helps,
Willy

           reply	other threads:[~2015-07-27  5:22 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CAOtoAkdAArhXQCWsFq6Gk2-rZudY819HEtOJNuJzGxL5zNiEcg@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727052144.GB19418@1wt.eu \
    --to=w@1wt.eu \
    --cc=buytenh@gnu.org \
    --cc=const-g@xpert.com \
    --cc=ctindel@ieee.org \
    --cc=davem@redhat.com \
    --cc=fubar@us.ibm.com \
    --cc=girouard@us.ibm.com \
    --cc=greearb@candelatech.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nick@dccinc.com \
    --cc=tadavis@lbl.gov \
    --cc=xqjcool@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).