From: Stephen Hemminger <stephen@networkplumber.org>
To: Lawrence Brakmo <brakmo@fb.com>
Cc: netdev <netdev@vger.kernel.org>, Kernel Team <kernel-team@fb.com>,
Neal Cardwell <ncardwell@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked()
Date: Mon, 27 Jul 2015 11:46:01 -0700 [thread overview]
Message-ID: <20150727114601.42fc6b63@urahara> (raw)
In-Reply-To: <1437792426-1724090-2-git-send-email-brakmo@fb.com>
On Fri, 24 Jul 2015 19:47:03 -0700
Lawrence Brakmo <brakmo@fb.com> wrote:
> Replace 2 arguments (cnt and rtt) in the congestion control modules'
> pkts_acked() function with a struct. This will allow adding more
> information without having to modify existing congestion control
> modules (tcp_nv in particular needs bytes in flight when packet
> was sent).
>
> As proposed by Neal Cardwell in his comments to the tcp_nv patch.
Adding a layer of indirection makes code changes easier, but makes
the code slower. Arguments are passed in registers, and putting an
additional level of indirection only matters if you can't change
all the CC modules. Since this is the kernel and API compatability
doesn't matter, just pass more arguments.
next prev parent reply other threads:[~2015-07-27 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 2:47 [RFC PATCH v4 net-next 0/4] tcp: add NV congestion control Lawrence Brakmo
2015-07-25 2:47 ` [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked() Lawrence Brakmo
2015-07-25 6:22 ` Eric Dumazet
2015-07-27 18:46 ` Stephen Hemminger [this message]
2015-07-27 19:30 ` Lawrence Brakmo
2015-07-28 3:42 ` Alexei Starovoitov
2015-07-25 2:47 ` [RFC PATCH v4 net-next 2/4] tcp: refactor struct tcp_skb_cb Lawrence Brakmo
2015-07-25 2:47 ` [RFC PATCH v4 net-next 3/4] tcp: add in_flight to tcp_skb_cb Lawrence Brakmo
2015-07-25 2:47 ` [RFC PATCH v4 net-next 4/4] tcp: add NV congestion control Lawrence Brakmo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150727114601.42fc6b63@urahara \
--to=stephen@networkplumber.org \
--cc=brakmo@fb.com \
--cc=eric.dumazet@gmail.com \
--cc=kernel-team@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).