From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client
Date: Tue, 4 Aug 2015 19:53:02 +0200 [thread overview]
Message-ID: <20150804175302.GA19650@salvia> (raw)
In-Reply-To: <1438037606-5462-1-git-send-email-phil@nwl.cc>
On Tue, Jul 28, 2015 at 12:53:26AM +0200, Phil Sutter wrote:
> Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK to
> finish the server handshake, then calls nf_ct_seqadj_init() to initiate
> sequence number adjustment of forwarded packets to the client and finally sends
> a window update to the client to unblock it's TX queue.
>
> Since synproxy_send_client_ack() does not set synproxy_send_tcp()'s nfct
> parameter, no sequence number adjustment happens and the client receives the
> window update with incorrect sequence number. Depending on client TCP
> implementation, this leads to a significant delay (until a window probe is
> being sent).
Could you also fix the IPv6 side to get both codes in sync? Thanks.
next prev parent reply other threads:[~2015-08-04 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 22:53 [PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client Phil Sutter
2015-08-04 17:53 ` Pablo Neira Ayuso [this message]
2015-08-06 12:34 ` [PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference Phil Sutter
2015-08-06 12:34 ` [PATCH 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client Phil Sutter
2015-08-08 15:57 ` [PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference Patrick McHardy
2015-08-09 11:14 ` [PATCH v2 " Phil Sutter
2015-08-09 11:14 ` [PATCH v2 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client Phil Sutter
2015-08-10 8:06 ` Patrick McHardy
2015-08-10 11:58 ` Pablo Neira Ayuso
2015-08-10 7:57 ` [PATCH v2 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference Patrick McHardy
2015-08-10 11:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804175302.GA19650@salvia \
--to=pablo@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).