From: Florian Westphal <fw@strlen.de>
To: "Nikola Forró" <nforro@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2] net: Fix behaviour of unreachable, blackhole and prohibit routes
Date: Thu, 3 Sep 2015 11:13:59 +0200 [thread overview]
Message-ID: <20150903091359.GB6328@breakpoint.cc> (raw)
In-Reply-To: <1441271331.3360.36.camel@redhat.com>
Nikola Forró <nforro@redhat.com> wrote:
> Man page of ip-route(8) says following about route types:
>
> unreachable - these destinations are unreachable. Packets are dis‐
> carded and the ICMP message host unreachable is generated. The local
> senders get an EHOSTUNREACH error.
>
> blackhole - these destinations are unreachable. Packets are dis‐
> carded silently. The local senders get an EINVAL error.
>
> prohibit - these destinations are unreachable. Packets are discarded
> and the ICMP message communication administratively prohibited is
> generated. The local senders get an EACCES error.
>
> In the inet6 address family, this was correct, except the local senders
> got ENETUNREACH error instead of EHOSTUNREACH in case of unreachable route.
> In the inet address family, all three route types generated ICMP message
> net unreachable, and the local senders got ENETUNREACH error.
>
> In both address families all three route types now behave consistently
> with documentation.
>
> Signed-off-by: Nikola Forró <nforro@redhat.com>
> ---
> include/net/ip_fib.h | 21 ++++++++++++++++-----
> net/ipv4/route.c | 6 ++++--
> net/ipv6/route.c | 4 +++-
> 3 files changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
> index 5fa643b..cf025107 100644
> --- a/include/net/ip_fib.h
> +++ b/include/net/ip_fib.h
> @@ -233,8 +233,10 @@ static inline int fib_lookup(struct net *net, const struct flowi4 *flp,
> rcu_read_lock();
>
> tb = fib_get_table(net, RT_TABLE_MAIN);
> - if (tb && !fib_table_lookup(tb, flp, res, flags | FIB_LOOKUP_NOREF))
> - err = 0;
> + if (tb)
> + err = fib_table_lookup(tb, flp, res, flags | FIB_LOOKUP_NOREF);
> + if (err == -EAGAIN)
> + err = -ENETUNREACH;
Missing { } ?
next prev parent reply other threads:[~2015-09-03 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:08 [PATCH v2] net: Fix behaviour of unreachable, blackhole and prohibit routes Nikola Forró
2015-09-03 9:13 ` Florian Westphal [this message]
2015-09-03 10:01 ` Nikola Forró
2015-09-03 17:29 ` David Miller
2015-09-03 22:22 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903091359.GB6328@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nforro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).