From: David Miller <davem@davemloft.net>
To: phil@nwl.cc
Cc: netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [net-next PATCH v2] net: ipv6: use common fib_default_rule_pref
Date: Tue, 08 Sep 2015 22:37:05 -0700 (PDT) [thread overview]
Message-ID: <20150908.223705.1178974104676916256.davem@davemloft.net> (raw)
In-Reply-To: <1441534858-6452-1-git-send-email-phil@nwl.cc>
From: Phil Sutter <phil@nwl.cc>
Date: Sun, 6 Sep 2015 12:20:58 +0200
> This switches IPv6 policy routing to use the shared
> fib_default_rule_pref() function of IPv4 and DECnet. It is also used in
> multicast routing for IPv4 as well as IPv6.
>
> The motivation for this patch is a complaint about iproute2 behaving
> inconsistent between IPv4 and IPv6 when adding policy rules: Formerly,
> IPv6 rules were assigned a fixed priority of 0x3FFF whereas for IPv4 the
> assigned priority value was decreased with each rule added.
>
> Since then all users of the default_pref field have been converted to
> assign the generic function fib_default_rule_pref(), fib_nl_newrule()
> may just use it directly instead. Therefore get rid of the function
> pointer altogether and make fib_default_rule_pref() static, as it's not
> used outside fib_rules.c anymore.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> Changes since v1:
> - Folded together with API change and adjusted commit message accordingly.
Applied, thanks.
next prev parent reply other threads:[~2015-09-09 5:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 13:03 [net-next PATCH] net: ipv6: use common fib_default_rule_pref Phil Sutter
2015-09-02 18:34 ` David Miller
2015-09-02 18:46 ` Thomas Graf
2015-09-03 11:10 ` [net-next PATCH] net: kill default_pref field of struct fib_rules_ops Phil Sutter
2015-09-06 5:00 ` David Miller
2015-09-06 9:54 ` Phil Sutter
2015-09-06 10:20 ` [net-next PATCH v2] net: ipv6: use common fib_default_rule_pref Phil Sutter
2015-09-09 5:37 ` David Miller [this message]
2015-09-09 5:38 ` David Miller
2015-09-09 11:45 ` Phil Sutter
2015-09-09 12:20 ` [net-next PATCH v3] " Phil Sutter
2015-09-09 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908.223705.1178974104676916256.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).