From: David Miller <davem@davemloft.net>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us,
siva.mannem.lnx@gmail.com, pjonnala@broadcom.com,
stephen@networkplumber.org, roopa@cumulusnetworks.com,
andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next 0/4] switchdev: push bridge attributes down
Date: Mon, 28 Sep 2015 22:07:15 -0700 (PDT) [thread overview]
Message-ID: <20150928.220715.1323851557788272372.davem@davemloft.net> (raw)
In-Reply-To: <1443128370-27353-1-git-send-email-sfeldma@gmail.com>
From: sfeldma@gmail.com
Date: Thu, 24 Sep 2015 13:59:26 -0700
> From: Scott Feldman <sfeldma@gmail.com>
>
> Push bridge-level attributes down to switchdev drivers. This patchset
> adds the infrastructure and then pushes, as an example, ageing_time attribute
> down from bridge to switchdev (rocker) driver. Add some range-checking
> for ageing_time.
>
> # ip link set dev br0 type bridge ageing_time 1000
>
> # ip link set dev br0 type bridge ageing_time 999
> RTNETLINK answers: Numerical result out of range
>
> Up until now, switchdev attrs where port-level attrs, so the netdev used in
> switchdev_attr_set() would be a switch port or bond of switch ports. With
> bridge-level attrs, the netdev passed to switchdev_attr_set() is the bridge
> netdev. The same recusive algo is used to visit the leaves of the stacked
> drivers to set the attr, it's just in this case we start one layer higher in
> the stack. One note is not all ports in the bridge may support setting a
> bridge-level attribute, so rather than failing the entire set, we'll skip over
> those ports returning -EOPNOTSUPP.
This doesn't apply cleanly to net-next, please respin.
Thanks.
prev parent reply other threads:[~2015-09-29 5:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 20:59 [PATCH net-next 0/4] switchdev: push bridge attributes down sfeldma
2015-09-24 20:59 ` [PATCH net-next 1/4] switchdev: add bridge attributes sfeldma
2015-09-25 4:32 ` Premkumar Jonnala
2015-09-25 5:51 ` David Miller
2015-09-24 20:59 ` [PATCH net-next 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports sfeldma
2015-09-25 4:33 ` Premkumar Jonnala
2015-09-24 20:59 ` [PATCH net-next 3/4] bridge: push bridge setting ageing_time down to switchdev sfeldma
2015-09-24 20:59 ` [PATCH net-next 4/4] rocker: handle setting bridge ageing_time sfeldma
2015-09-24 21:05 ` [PATCH net-next 0/4] switchdev: push bridge attributes down Stephen Hemminger
2015-09-25 3:25 ` Scott Feldman
2015-09-25 3:47 ` Stephen Hemminger
2015-09-25 1:23 ` Florian Fainelli
2015-09-25 1:53 ` Andrew Lunn
2015-09-25 4:26 ` Scott Feldman
2015-09-29 5:22 ` Florian Fainelli
2015-09-29 5:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928.220715.1323851557788272372.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pjonnala@broadcom.com \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=siva.mannem.lnx@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).