From: Andy Gospodarek <gospo@cumulusnetworks.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCHv3 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction
Date: Fri, 30 Oct 2015 12:53:27 -0400 [thread overview]
Message-ID: <20151030165326.GA8027@gospo.home.greyhouse.net> (raw)
In-Reply-To: <1446193414-8244-1-git-send-email-ja@ssi.bg>
On Fri, Oct 30, 2015 at 10:23:32AM +0200, Julian Anastasov wrote:
> Fix two problems from the change that introduced RTNH_F_LINKDOWN
> flag. The first patch deals with the removal of local route on
> DOWN event. The second patch makes sure the RTNH_F_LINKDOWN
> flag is properly updated on UP event because the DOWN event
> sets it in all cases.
>
> v2->v3:
> - use bool for force var
>
> v1->v2:
> - forgot to add ifconfig dummy0 down in the test case
> - split to 2 patches
>
> Julian Anastasov (2):
> ipv4: fix to not remove local route on link down
> ipv4: update RTNH_F_LINKDOWN flag on UP event
I had a chance to test both of these this morning and they look good.
Sorry for the delay. Thanks for making force a bool to cover the single
case -- good suggestion by DaveM.
Reviewed-by: Andy Gospodarek <gospo@cumulusnetworks.com>
next prev parent reply other threads:[~2015-10-30 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 8:23 [PATCHv3 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction Julian Anastasov
2015-10-30 8:23 ` [PATCHv3 net 1/2] ipv4: fix to not remove local route on link down Julian Anastasov
2015-10-30 8:23 ` [PATCHv3 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event Julian Anastasov
2015-10-30 16:53 ` Andy Gospodarek [this message]
2015-11-01 21:58 ` [PATCHv3 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030165326.GA8027@gospo.home.greyhouse.net \
--to=gospo@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).