netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: David Ahern <dsahern@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <eladr@mellanox.com>,
	<yotamg@mellanox.com>, <stephen@networkplumber.org>,
	Jiri Pirko <jiri@mellanox.com>
Subject: Re: [patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies
Date: Mon, 21 Dec 2015 18:50:38 +0200	[thread overview]
Message-ID: <20151221165021.GA22302@colbert.mtl.com> (raw)
In-Reply-To: <5678206F.8050104@gmail.com>

Mon, Dec 21, 2015 at 05:53:19PM IST, dsahern@gmail.com wrote:
>On 12/21/15 3:56 AM, Jiri Pirko wrote:
>> diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
>> index 5396ff08..12045de 100644
>> --- a/net/bridge/br_stp_if.c
>> +++ b/net/bridge/br_stp_if.c
>> @@ -39,7 +39,7 @@ void br_init_port(struct net_bridge_port *p)
>>   	struct switchdev_attr attr = {
>>   		.id = SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME,
>>   		.flags = SWITCHDEV_F_SKIP_EOPNOTSUPP | SWITCHDEV_F_DEFER,
>> -		.u.ageing_time = p->br->ageing_time,
>> +		.u.ageing_time = jiffies_to_clock_t(p->br->ageing_time),
>>   	};
>>   	int err;
>
>
>ageing_time is a u32; clock_t is a long.

Hi,

p->br->ageing_time is set in br_set_ageing_time, where it's converted to
jiffies from clock_t, that is treated as u32.

  reply	other threads:[~2015-12-21 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21  8:56 [patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies Jiri Pirko
2015-12-21 15:53 ` David Ahern
2015-12-21 16:50   ` Ido Schimmel [this message]
2015-12-22 20:57 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221165021.GA22302@colbert.mtl.com \
    --to=idosch@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=eladr@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).