From: David Miller <davem@davemloft.net>
To: vegard.nossum@oracle.com
Cc: acme@kernel.org, edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dccp: fix use-after-free after cloning struct dccp_sock
Date: Tue, 22 Dec 2015 15:34:25 -0500 (EST) [thread overview]
Message-ID: <20151222.153425.727988801786072877.davem@davemloft.net> (raw)
In-Reply-To: <1450644807-852-1-git-send-email-vegard.nossum@oracle.com>
From: Vegard Nossum <vegard.nossum@oracle.com>
Date: Sun, 20 Dec 2015 21:53:27 +0100
> @@ -115,6 +115,10 @@ struct sock *dccp_create_openreq_child(const struct sock *sk,
> newdp->dccps_isr = dreq->dreq_isr;
> newdp->dccps_gsr = dreq->dreq_gsr;
>
> + newdp->dccps_hc_rx_ackvec = NULL;
> + newdp->dccps_hc_rx_ccid = NULL;
> + newdp->dccps_hc_tx_ccid = NULL;
->dccps_hc_rx_ackvec is set to NULL several lines above this, so you don't
need to add that case here.
WRT the ccid pointers, I don't think we can just NULL them out.
If the parent socket has these CCID features enabled, we have to
clone them into the child somehow.
prev parent reply other threads:[~2015-12-22 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 20:53 [PATCH] dccp: fix use-after-free after cloning struct dccp_sock Vegard Nossum
2015-12-22 20:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222.153425.727988801786072877.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).